You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/09 01:00:32 UTC

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1816: bugfix: symbol would be encoded to 0x3f when using proxy-rewrite directive

spacewander commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451904860



##########
File path: apisix/plugins/proxy-rewrite.lua
##########
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
         end
     end
 
-    upstream_uri = core.utils.uri_safe_encode(upstream_uri)
+    local index, _ = find_str(upstream_uri, "?")

Review comment:
       Should use plain text style `string.find`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org