You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dirk Krummacker (JIRA)" <de...@myfaces.apache.org> on 2008/05/27 11:07:55 UTC

[jira] Created: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Wrong key used for property "page-flow-scope-lifetime"
------------------------------------------------------

                 Key: TRINIDAD-1095
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions:  1.0.8-core, 1.0.7-core
         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
            Reporter: Dirk Krummacker
            Priority: Minor


The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.

Either the documemtation is outdated or the implementation was not changed (or regressed somehow).

----- RequestContextImpl.java -----

  int __getPageFlowScopeLifetime()
  {
    Integer lifetimeObj = (Integer) _bean.getProperty(
                           RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
    if (lifetimeObj == null)
      return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
    return lifetimeObj.intValue();
  }

----- RequestContextBean.java -----

  static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
    TYPE.registerKey("process-scope-lifetime",
                     Integer.class,
                     PropertyKey.CAP_NOT_BOUND);

----- End -----

Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Posted by "Dirk Krummacker (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dirk Krummacker updated TRINIDAD-1095:
--------------------------------------

    Status: Patch Available  (was: Open)

> Wrong key used for property "page-flow-scope-lifetime"
> ------------------------------------------------------
>
>                 Key: TRINIDAD-1095
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.7-core,  1.0.8-core
>         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
>            Reporter: Dirk Krummacker
>            Priority: Minor
>
> The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.
> Either the documemtation is outdated or the implementation was not changed (or regressed somehow).
> ----- RequestContextImpl.java -----
>   int __getPageFlowScopeLifetime()
>   {
>     Integer lifetimeObj = (Integer) _bean.getProperty(
>                            RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
>     if (lifetimeObj == null)
>       return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
>     return lifetimeObj.intValue();
>   }
> ----- RequestContextBean.java -----
>   static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
>     TYPE.registerKey("process-scope-lifetime",
>                      Integer.class,
>                      PropertyKey.CAP_NOT_BOUND);
> ----- End -----
> Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Posted by "Dirk Krummacker (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dirk Krummacker updated TRINIDAD-1095:
--------------------------------------

    Status: Patch Available  (was: Open)

> Wrong key used for property "page-flow-scope-lifetime"
> ------------------------------------------------------
>
>                 Key: TRINIDAD-1095
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.7-core,  1.0.8-core
>         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
>            Reporter: Dirk Krummacker
>            Priority: Minor
>         Attachments: page-flow-scope-lifetime-patch.txt
>
>
> The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.
> Either the documemtation is outdated or the implementation was not changed (or regressed somehow).
> ----- RequestContextImpl.java -----
>   int __getPageFlowScopeLifetime()
>   {
>     Integer lifetimeObj = (Integer) _bean.getProperty(
>                            RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
>     if (lifetimeObj == null)
>       return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
>     return lifetimeObj.intValue();
>   }
> ----- RequestContextBean.java -----
>   static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
>     TYPE.registerKey("process-scope-lifetime",
>                      Integer.class,
>                      PropertyKey.CAP_NOT_BOUND);
> ----- End -----
> Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Posted by "Dirk Krummacker (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dirk Krummacker updated TRINIDAD-1095:
--------------------------------------

    Status: Open  (was: Patch Available)

> Wrong key used for property "page-flow-scope-lifetime"
> ------------------------------------------------------
>
>                 Key: TRINIDAD-1095
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.7-core,  1.0.8-core
>         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
>            Reporter: Dirk Krummacker
>            Priority: Minor
>
> The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.
> Either the documemtation is outdated or the implementation was not changed (or regressed somehow).
> ----- RequestContextImpl.java -----
>   int __getPageFlowScopeLifetime()
>   {
>     Integer lifetimeObj = (Integer) _bean.getProperty(
>                            RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
>     if (lifetimeObj == null)
>       return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
>     return lifetimeObj.intValue();
>   }
> ----- RequestContextBean.java -----
>   static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
>     TYPE.registerKey("process-scope-lifetime",
>                      Integer.class,
>                      PropertyKey.CAP_NOT_BOUND);
> ----- End -----
> Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated TRINIDAD-1095:
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.9-core
                   1.0.9-core
           Status: Resolved  (was: Patch Available)

Thanks to Dirk Krummacker for his patch.

> Wrong key used for property "page-flow-scope-lifetime"
> ------------------------------------------------------
>
>                 Key: TRINIDAD-1095
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.7-core,  1.0.8-core
>         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
>            Reporter: Dirk Krummacker
>            Assignee: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.0.9-core, 1.2.9-core
>
>         Attachments: page-flow-scope-lifetime-patch.txt
>
>
> The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.
> Either the documemtation is outdated or the implementation was not changed (or regressed somehow).
> ----- RequestContextImpl.java -----
>   int __getPageFlowScopeLifetime()
>   {
>     Integer lifetimeObj = (Integer) _bean.getProperty(
>                            RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
>     if (lifetimeObj == null)
>       return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
>     return lifetimeObj.intValue();
>   }
> ----- RequestContextBean.java -----
>   static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
>     TYPE.registerKey("process-scope-lifetime",
>                      Integer.class,
>                      PropertyKey.CAP_NOT_BOUND);
> ----- End -----
> Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Posted by "Dirk Krummacker (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dirk Krummacker updated TRINIDAD-1095:
--------------------------------------

    Status: Open  (was: Patch Available)

> Wrong key used for property "page-flow-scope-lifetime"
> ------------------------------------------------------
>
>                 Key: TRINIDAD-1095
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.7-core,  1.0.8-core
>         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
>            Reporter: Dirk Krummacker
>            Priority: Minor
>
> The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.
> Either the documemtation is outdated or the implementation was not changed (or regressed somehow).
> ----- RequestContextImpl.java -----
>   int __getPageFlowScopeLifetime()
>   {
>     Integer lifetimeObj = (Integer) _bean.getProperty(
>                            RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
>     if (lifetimeObj == null)
>       return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
>     return lifetimeObj.intValue();
>   }
> ----- RequestContextBean.java -----
>   static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
>     TYPE.registerKey("process-scope-lifetime",
>                      Integer.class,
>                      PropertyKey.CAP_NOT_BOUND);
> ----- End -----
> Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1095) Wrong key used for property "page-flow-scope-lifetime"

Posted by "Dirk Krummacker (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dirk Krummacker updated TRINIDAD-1095:
--------------------------------------

    Status: Patch Available  (was: Open)

> Wrong key used for property "page-flow-scope-lifetime"
> ------------------------------------------------------
>
>                 Key: TRINIDAD-1095
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1095
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.7-core,  1.0.8-core
>         Environment: Observed with Windows XP, IE6 or Firefox 2.0.0.14, Apache MyFaces Core 1.1.5 and Trinidad 1.0.7 and 1.0.8.
>            Reporter: Dirk Krummacker
>            Priority: Minor
>
> The developer's guide on http://myfaces.apache.org/trinidad/devguide/configuration.html#trinidad-config.xml documents the property to set the number of pageFlowScope instances as having the name "page-flow-scope-lifetime". However, in the implementation of Trinidad 1.0.7 and 1.0.8 the name "process-scope-lifetime" is used instead.
> Either the documemtation is outdated or the implementation was not changed (or regressed somehow).
> ----- RequestContextImpl.java -----
>   int __getPageFlowScopeLifetime()
>   {
>     Integer lifetimeObj = (Integer) _bean.getProperty(
>                            RequestContextBean.PAGE_FLOW_SCOPE_LIFETIME_KEY);
>     if (lifetimeObj == null)
>       return _DEFAULT_PAGE_FLOW_SCOPE_LIFETIME;
>     return lifetimeObj.intValue();
>   }
> ----- RequestContextBean.java -----
>   static public final PropertyKey PAGE_FLOW_SCOPE_LIFETIME_KEY =
>     TYPE.registerKey("process-scope-lifetime",
>                      Integer.class,
>                      PropertyKey.CAP_NOT_BOUND);
> ----- End -----
> Proposed solution: Please change the literal in RequestContextBean.java from "process-scope-lifetime" to the documented value. It would also be possible (for backwards compatibility) to check for both keys and use the one that is set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.