You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "yigress (via GitHub)" <gi...@apache.org> on 2023/02/08 21:48:15 UTC
[GitHub] [hive] yigress opened a new pull request, #4046: HIVE-27016: Invoke optional output committer in TezProcessor for FileSink
yigress opened a new pull request, #4046:
URL: https://github.com/apache/hive/pull/4046
### What changes were proposed in this pull request?
In case of multi-insert and statistics auto-gathering, the leaf vertex may not include the filesinkoperator. This is to add datasink for vertex that has FileSinkOperator. It is done in HIVE-4.0 by HIVE-25276 for hive-iceberge. This is to add this condition into HIVE-3.2.0 as well.
### Why are the changes needed?
To fix issues with multi-insert and auto-stats for StorageHandler to use customized OutputCommitter in Tez.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
local test with storagehandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4046: HIVE-27016 (addendum): Invoke optional output committer in TezProcessor for FileSink
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4046:
URL: https://github.com/apache/hive/pull/4046#issuecomment-1435051139
@zabetak Thank you for working hard to bring branch-3 to release, users are looking forward to a new release in Hive. I completely agree that right now stabilizing the branch-3 tests is the first priority, as I see that due to tests not green, it is hard to mend tests as well.
Rather than revert this commit, can we continue with test case fix in https://github.com/apache/hive/pull/4068#issuecomment-1435041562 ? The reason is that in branch-4 the test cases are fixed by HIVE-22589, maybe the test cases should have been fixed sooner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on pull request #4046: HIVE-27016 (addendum): Invoke optional output committer in TezProcessor for FileSink
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4046:
URL: https://github.com/apache/hive/pull/4046#issuecomment-1434503405
Hey @sunchao and @yigress at this point the scope for branch-3 is only to address test failures. This PR along with other recent merges do not seem to address test failures. Please check https://lists.apache.org/thread/grwo0y7w6h4jfo3tld2s05onbp96moy1 and comment there if you have a different opinion. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #4046: HIVE-27016 (addendum): Invoke optional output committer in TezProcessor for FileSink
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao merged PR #4046:
URL: https://github.com/apache/hive/pull/4046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org