You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/10/20 10:44:32 UTC
Re: Review Request 37998: Made ProcessManager::handle() a void
returning method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 10:44 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase to new dependency.
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
`ProcessManager::handle()` is a method used to process HTTP requests, its signature returns a boolean which is not used anywhere and it doesn't allow for asynchronous operations within handle.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271
Diff: https://reviews.apache.org/r/37998/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 37998: Made ProcessManager::handle() a void
returning method.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/#review106649
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Nov. 16, 2015, 1:48 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37998/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 1:48 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `ProcessManager::handle()` is a method used to process HTTP requests, its signature returns a boolean which is not used anywhere and it doesn't allow for asynchronous operations within handle.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp b45b5b14cc7868d73a6fe02c02b9baf8b44b891f
>
> Diff: https://reviews.apache.org/r/37998/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 37998: Made ProcessManager::handle() a void
returning method.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 10:48 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebasing.
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
`ProcessManager::handle()` is a method used to process HTTP requests, its signature returns a boolean which is not used anywhere and it doesn't allow for asynchronous operations within handle.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp b45b5b14cc7868d73a6fe02c02b9baf8b44b891f
Diff: https://reviews.apache.org/r/37998/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 37998: Made ProcessManager::handle() a void
returning method.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 4:58 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
`ProcessManager::handle()` is a method used to process HTTP requests, its signature returns a boolean which is not used anywhere and it doesn't allow for asynchronous operations within handle.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
Diff: https://reviews.apache.org/r/37998/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 37998: Made ProcessManager::handle() a void
returning method.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 6:07 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
rebase
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
`ProcessManager::handle()` is a method used to process HTTP requests, its signature returns a boolean which is not used anywhere and it doesn't allow for asynchronous operations within handle.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
Diff: https://reviews.apache.org/r/37998/diff/
Testing
-------
make check
Thanks,
Alexander Rojas