[GitHub] [spark] Daniel-Davies commented on a change in pull request #35032: [SPARK-37738][PySpark] Fix API skew in PySpark date functions

[GitBox <gi...@apache.org>]

Daniel-Davies commented on a change in pull request #35032:
URL: https://github.com/apache/spark/pull/35032#discussion_r775499711



##########
File path: python/pyspark/sql/functions.py
##########
@@ -2200,38 +2200,70 @@ def make_date(year: "ColumnOrName", month: "ColumnOrName", day: "ColumnOrName")
     return Column(jc)
 
 
+@overload
+def date_add(start: "ColumnOrName", days: "ColumnOrName") -> Column:
+    ...
+
+
+@overload
 def date_add(start: "ColumnOrName", days: int) -> Column:
+    ...

Review comment:
       ack- will remove, thank you! I thought it would be a good idea for consistency with the other functions, but you're right in that date_add (+ others I've modified) will output the same thing regardless




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org