[jira] [Commented] (MESOS-6706) Port `files_tests.cpp`

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752840#comment-15752840 ] 

Joseph Wu commented on MESOS-6706:
----------------------------------

{code}
commit c1578bb74929440c37bd9f393af5e55efee3c67d
Author: Alex Clemmer <cl...@gmail.com>
Date:   Thu Dec 15 15:08:14 2016 -0800

    Windows: Disambiguated `os::write` by adding another overload.
    
    This commit will address test failures on Windows in `files_tests.cpp`.
    On Windows, calling `os::write` with a `char *` literal (e.g.,
    `os::write("your_file", ...)` will erroneously dispatch to the overload
    of `os::write(HANDLE)` instead of `os::write(const string&)`, because
    `HANDLE` is a typedef'd `void *`.
    
    In this commit, we simply add an overload for `char *`, which resolves
    the ambiguity and causes most tests in `files_tests.cpp` to pass.
    
    Review: https://reviews.apache.org/r/54631/
{code}

> Port `files_tests.cpp`
> ----------------------
>
>                 Key: MESOS-6706
>                 URL: https://issues.apache.org/jira/browse/MESOS-6706
>             Project: Mesos
>          Issue Type: Bug
>          Components: agent
>            Reporter: Alex Clemmer
>            Assignee: Alex Clemmer
>              Labels: microsoft, windows-mvp
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)