You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/16 03:47:14 UTC
[GitHub] [incubator-inlong] LvJiancheng opened a new pull request, #3750: [INLONG-3745] manager-plugis fix canstants bug of savepointDirectory
LvJiancheng opened a new pull request, #3750:
URL: https://github.com/apache/incubator-inlong/pull/3750
### Title Name: [INLONG-3745] manager-plugis fix canstants bug
where *XYZ* should be replaced by the actual issue number.
Fixes #3745
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #3750: [INLONG-3745][Manager] Manager-plugins fix canstants bug of savepointDirectory
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #3750:
URL: https://github.com/apache/incubator-inlong/pull/3750#issuecomment-1100594596
fixed by https://github.com/apache/incubator-inlong/pull/3754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] LvJiancheng commented on a diff in pull request #3750: [INLONG-3745][Manager] Manager-plugins fix canstants bug of savepointDirectory
Posted by GitBox <gi...@apache.org>.
LvJiancheng commented on code in PR #3750:
URL: https://github.com/apache/incubator-inlong/pull/3750#discussion_r851586258
##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/IntegrationTaskRunner.java:
##########
@@ -79,7 +79,8 @@ public void run() {
try {
StopWithSavepointRequest stopWithSavepointRequest = new StopWithSavepointRequest();
stopWithSavepointRequest.setDrain(Constants.DRAIN);
Review Comment:
yeah,the conf is fixed false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #3750: [INLONG-3745][Manager] Manager-plugins fix canstants bug of savepointDirectory
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #3750:
URL: https://github.com/apache/incubator-inlong/pull/3750#discussion_r851584222
##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/IntegrationTaskRunner.java:
##########
@@ -79,7 +79,8 @@ public void run() {
try {
StopWithSavepointRequest stopWithSavepointRequest = new StopWithSavepointRequest();
stopWithSavepointRequest.setDrain(Constants.DRAIN);
Review Comment:
Constants.DRAIN is not right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow closed pull request #3750: [INLONG-3745][Manager] Manager-plugins fix canstants bug of savepointDirectory
Posted by GitBox <gi...@apache.org>.
healchow closed pull request #3750: [INLONG-3745][Manager] Manager-plugins fix canstants bug of savepointDirectory
URL: https://github.com/apache/incubator-inlong/pull/3750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org