You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/16 02:50:38 UTC

[GitHub] [zookeeper] maoling commented on a change in pull request #1181: ZOOKEEPER-2313 Refactor ZooKeeperServerBean and its subclasses

maoling commented on a change in pull request #1181: ZOOKEEPER-2313 Refactor ZooKeeperServerBean and its subclasses
URL: https://github.com/apache/zookeeper/pull/1181#discussion_r358034734
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerBean.java
 ##########
 @@ -40,6 +40,12 @@ public ZooKeeperServerBean(ZooKeeperServer zks) {
         name = "StandaloneServer_port" + zks.getClientPort();
     }
 
 
 Review comment:
   -  `name = "StandaloneServer";` is OK, don't need the port? `StandaloneServer_port2181`? `StandaloneServer_port:2181`, `StandaloneServer_port_2181`:)
   -  +1 for the moving of `ObserverBean`
   - `ReadOnlyBean`  has been forgotten?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services