[GitHub] [spark] viirya commented on a diff in pull request #40688: [SPARK-43021][SQL] `CoalesceBucketsInJoin` not work when using AQE

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #40688:
URL: https://github.com/apache/spark/pull/40688#discussion_r1160479528


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/InsertAdaptiveSparkPlan.scala:
##########
@@ -60,6 +61,7 @@ case class InsertAdaptiveSparkPlan(
           val subqueryMap = buildSubqueryMap(plan)
           val planSubqueriesRule = PlanAdaptiveSubqueries(subqueryMap)
           val preprocessingRules = Seq(
+            CoalesceBucketsInJoin,
             planSubqueriesRule)

Review Comment:
   Hmm, why don't put into `queryStagePreparationRules`? These no-op physical rules including `DisableUnnecessaryBucketedScan` are put there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org