[GitHub] [accumulo] keith-turner commented on a diff in pull request #3319: Remove Bulk Import v1 from main

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3319:
URL: https://github.com/apache/accumulo/pull/3319#discussion_r1171315784


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -672,10 +651,6 @@ interface ImportDestinationArguments {
    * Bulk import the files in a directory into a table. Files can be created using
    * {@link RFile#newWriter()}.
    * <p>
-   * This new method of bulk import examines files in the current process outside of holding a table

Review Comment:
   We can still document that files are examined client side w/o mentioning old bulk import.  Maybe something like.
   
   ```
   The files are examined on the client side to determine destination tablets.  This examination will use memory and cpu within the process calling this API.
   ```



##########
core/src/main/thrift/client.thrift:
##########
@@ -46,13 +46,13 @@ enum TableOperationExceptionType {
   NOTFOUND
   OFFLINE
   BULK_BAD_INPUT_DIRECTORY
-  BULK_BAD_ERROR_DIRECTORY

Review Comment:
   Can you explain this rename to me?  Not sure what is going on here in the larger context.



##########
core/src/main/thrift/tabletingest.thrift:
##########
@@ -106,17 +106,6 @@ service TabletIngestClientService {
     2:data.UpdateID sessID
   )
 
-  // on success, returns an empty list
-  list<data.TKeyExtent> bulkImport(
-    3:client.TInfo tinfo
-    1:security.TCredentials credentials
-    4:i64 tid
-    2:data.TabletFiles files

Review Comment:
   I took quick look locally and this may be the only usage of this data.TabletFiles thrift type. If so, could remove it from the data.thrift file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org