You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2011/09/23 04:19:26 UTC
[jira] [Created] (MYFACES-3318) Documentation for insert ajax
command does not match with spec xsd
Documentation for insert ajax command does not match with spec xsd
------------------------------------------------------------------
Key: MYFACES-3318
URL: https://issues.apache.org/jira/browse/MYFACES-3318
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Reporter: Leonardo Uribe
The spec javascript documentation says this:
If an <insert> element is found in the response with the attribute before:
<insert id="insert id" before="before id">
<![CDATA[...]]>
</insert>
Extract this <insert> element's CDATA contents from the response.
Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
If an <insert> element is found in the response with the attribute after:
<insert id="insert id" after="after id">
<![CDATA[...]]>
</insert>
Extract this <insert> element's CDATA contents from the response.
Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
But JSF 2.0 Appendix A about partial response xml says it should be:
<insert>
<before id="before id">
<![CDATA[...]]>
</before>
</insert>
<insert>
<after id="after id">
<![CDATA[...]]>
</after>
</insert>
MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3318) Documentation for insert ajax
command does not match with spec xsd
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113201#comment-13113201 ]
Werner Punz commented on MYFACES-3318:
--------------------------------------
I think the best would be simply to implement both on the javascript side, since both parsing paths are not mutually exclusive.
insert before or after attribute set use the path from the jsdocs, insert with a separate before or after use the path from the spec.
That way the impl can decide which one to use, for me it is not really that much of additional work. I will add this stuff next week, when I work on the jsf.js impl again in myfaces.
> Documentation for insert ajax command does not match with spec xsd
> ------------------------------------------------------------------
>
> Key: MYFACES-3318
> URL: https://issues.apache.org/jira/browse/MYFACES-3318
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Reporter: Leonardo Uribe
> Attachments: MYFACES-3318-1.patch
>
>
> The spec javascript documentation says this:
> If an <insert> element is found in the response with the attribute before:
> <insert id="insert id" before="before id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
> If an <insert> element is found in the response with the attribute after:
> <insert id="insert id" after="after id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
> But JSF 2.0 Appendix A about partial response xml says it should be:
> <insert>
> <before id="before id">
> <![CDATA[...]]>
> </before>
> </insert>
> <insert>
> <after id="after id">
> <![CDATA[...]]>
> </after>
> </insert>
> MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MYFACES-3318) Documentation for insert ajax
command does not match with spec xsd
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Werner Punz resolved MYFACES-3318.
----------------------------------
Resolution: Fixed
added hooks now for table handling, and eval handling on insert before and after.
> Documentation for insert ajax command does not match with spec xsd
> ------------------------------------------------------------------
>
> Key: MYFACES-3318
> URL: https://issues.apache.org/jira/browse/MYFACES-3318
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Reporter: Leonardo Uribe
> Fix For: 2.0.10-SNAPSHOT, 2.1.4-SNAPSHOT
>
> Attachments: MYFACES-3318-1.patch
>
>
> The spec javascript documentation says this:
> If an <insert> element is found in the response with the attribute before:
> <insert id="insert id" before="before id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
> If an <insert> element is found in the response with the attribute after:
> <insert id="insert id" after="after id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
> But JSF 2.0 Appendix A about partial response xml says it should be:
> <insert>
> <before id="before id">
> <![CDATA[...]]>
> </before>
> </insert>
> <insert>
> <after id="after id">
> <![CDATA[...]]>
> </after>
> </insert>
> MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MYFACES-3318) Documentation for insert ajax
command does not match with spec xsd
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Werner Punz reopened MYFACES-3318:
----------------------------------
Ups I should not have closed it, it probably needs some patching on the myfaces side as well
> Documentation for insert ajax command does not match with spec xsd
> ------------------------------------------------------------------
>
> Key: MYFACES-3318
> URL: https://issues.apache.org/jira/browse/MYFACES-3318
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Reporter: Leonardo Uribe
> Fix For: 2.0.10-SNAPSHOT, 2.1.4-SNAPSHOT
>
> Attachments: MYFACES-3318-1.patch
>
>
> The spec javascript documentation says this:
> If an <insert> element is found in the response with the attribute before:
> <insert id="insert id" before="before id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
> If an <insert> element is found in the response with the attribute after:
> <insert id="insert id" after="after id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
> But JSF 2.0 Appendix A about partial response xml says it should be:
> <insert>
> <before id="before id">
> <![CDATA[...]]>
> </before>
> </insert>
> <insert>
> <after id="after id">
> <![CDATA[...]]>
> </after>
> </insert>
> MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3318) Documentation for insert ajax
command does not match with spec xsd
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated MYFACES-3318:
------------------------------------
Status: Patch Available (was: Open)
> Documentation for insert ajax command does not match with spec xsd
> ------------------------------------------------------------------
>
> Key: MYFACES-3318
> URL: https://issues.apache.org/jira/browse/MYFACES-3318
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Reporter: Leonardo Uribe
> Attachments: MYFACES-3318-1.patch
>
>
> The spec javascript documentation says this:
> If an <insert> element is found in the response with the attribute before:
> <insert id="insert id" before="before id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
> If an <insert> element is found in the response with the attribute after:
> <insert id="insert id" after="after id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
> But JSF 2.0 Appendix A about partial response xml says it should be:
> <insert>
> <before id="before id">
> <![CDATA[...]]>
> </before>
> </insert>
> <insert>
> <after id="after id">
> <![CDATA[...]]>
> </after>
> </insert>
> MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3318) Documentation for insert ajax
command does not match with spec xsd
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Werner Punz updated MYFACES-3318:
---------------------------------
Resolution: Fixed
Fix Version/s: 2.1.4-SNAPSHOT
2.0.10-SNAPSHOT
Status: Resolved (was: Patch Available)
I did not apply the patch, but I added a second parsing path which covers the <insert><before id="... and <insert><after id="... case. I also took the freedom to refactor the code a little bit so that it becomes more readable than the old version.
As soon as myfaces itself is transformed to use only the spec parsing path I can reduce the code a little bit more.
For now both cases are covered, since they are not mutually exclusive.
> Documentation for insert ajax command does not match with spec xsd
> ------------------------------------------------------------------
>
> Key: MYFACES-3318
> URL: https://issues.apache.org/jira/browse/MYFACES-3318
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Reporter: Leonardo Uribe
> Fix For: 2.0.10-SNAPSHOT, 2.1.4-SNAPSHOT
>
> Attachments: MYFACES-3318-1.patch
>
>
> The spec javascript documentation says this:
> If an <insert> element is found in the response with the attribute before:
> <insert id="insert id" before="before id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
> If an <insert> element is found in the response with the attribute after:
> <insert id="insert id" after="after id">
> <![CDATA[...]]>
> </insert>
> Extract this <insert> element's CDATA contents from the response.
> Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
> But JSF 2.0 Appendix A about partial response xml says it should be:
> <insert>
> <before id="before id">
> <![CDATA[...]]>
> </before>
> </insert>
> <insert>
> <after id="after id">
> <![CDATA[...]]>
> </after>
> </insert>
> MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira