You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Zarar Siddiqi (JIRA)" <ji...@apache.org> on 2007/07/18 00:51:04 UTC
[jira] Created: (CXF-803) Configuring interceptors using
annotations
Configuring interceptors using annotations
------------------------------------------
Key: CXF-803
URL: https://issues.apache.org/jira/browse/CXF-803
Project: CXF
Issue Type: New Feature
Components: Configuration
Affects Versions: 2.0
Environment: All
Reporter: Zarar Siddiqi
It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
Thanks,
Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-803) Configuring interceptors using
annotations
Posted by "Zarar Siddiqi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515295 ]
Zarar Siddiqi commented on CXF-803:
-----------------------------------
This is excellent work Jeff. And fast too.
Thanks a lot!
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (CXF-803) Configuring interceptors using annotations
Posted by Freeman Fang <fr...@iona.com>.
Hi Jeff,
I will take care of this patch.
Regards
Freeman
Jeff Yu (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jeff Yu updated CXF-803:
> ------------------------
>
> Attachment: cxf-803-2.patch
>
> In this Patch, I added the @Features annotaion.
>
>
>> Configuring interceptors using annotations
>> ------------------------------------------
>>
>> Key: CXF-803
>> URL: https://issues.apache.org/jira/browse/CXF-803
>> Project: CXF
>> Issue Type: New Feature
>> Components: Configuration
>> Affects Versions: 2.0
>> Environment: All
>> Reporter: Zarar Siddiqi
>> Attachments: cxf-803-2.patch, cxf-803.patch
>>
>>
>> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
>> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
>> Thanks,
>> Zarar
>>
>
>
Re: [jira] Updated: (CXF-803) Configuring interceptors using annotations
Posted by Freeman Fang <fr...@iona.com>.
Hi Jeff,
I will take care of this patch.
Regards
Freeman
Jeff Yu (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jeff Yu updated CXF-803:
> ------------------------
>
> Attachment: cxf-803-2.patch
>
> In this Patch, I added the @Features annotaion.
>
>
>> Configuring interceptors using annotations
>> ------------------------------------------
>>
>> Key: CXF-803
>> URL: https://issues.apache.org/jira/browse/CXF-803
>> Project: CXF
>> Issue Type: New Feature
>> Components: Configuration
>> Affects Versions: 2.0
>> Environment: All
>> Reporter: Zarar Siddiqi
>> Attachments: cxf-803-2.patch, cxf-803.patch
>>
>>
>> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
>> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
>> Thanks,
>> Zarar
>>
>
>
[jira] Updated: (CXF-803) Configuring interceptors using
annotations
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Yu updated CXF-803:
------------------------
Attachment: cxf-803-2.patch
In this Patch, I added the @Features annotaion.
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-803) Configuring interceptors using
annotations
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved CXF-803.
-----------------------------
Resolution: Fixed
Patches have been applied and appears to work fine
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Fix For: 2.0.1
>
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-803) Configuring interceptors using
annotations
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517863 ]
Jeff Yu commented on CXF-803:
-----------------------------
Hi, Zarar
You are right, I havent tested it with the spring AOP scenario at that time, it might have some problems in this situation, well, as you've reported another issue, CXF-874, we will track this problem thru that JIRA.
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Fix For: 2.0.1
>
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-803) Configuring interceptors using
annotations
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Yu updated CXF-803:
------------------------
Attachment: cxf-803.patch
With this patch, I've added four annotations, they are: InInterceptors, OutInterceptors, InFaultInterceptors, OutFaultInterceptors.
You can add these annotation either on the SEI or service implementation, but when both of they are all specified, we are searching the service implementation first, if we can't find it on the service implementor, and then we find it on the SEI, which is specified by the "WebService"' annotation's "endpointInterface" attribute value. (This is as same as HandlerChain annotation logic, find the service implementation first, if it is null, and then search the SEI accordingly).
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-803) Configuring interceptors using
annotations
Posted by "Zarar Siddiqi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516555 ]
Zarar Siddiqi commented on CXF-803:
-----------------------------------
I've noticed that these annotations don't work when using JaxWS endpoints in conjunction with AOP.
If I have the following defined along with a nAOP MethodSecurityInterceptor, the services get created but the annotation processing is skipped.
<bean id="myService" class="com.mycompany.MyServiceImpl"/>
<jaxws:endpoint id="myServiceEndpoint" implementor="#myService" address="/MyService" />
I'm not sure if this is a problem with the code that's reading the annotations or if I have to configure the JaxWS endpoint differently if AOP is in play.
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Fix For: 2.0.1
>
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-803) Configuring interceptors using
annotations
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp updated CXF-803:
----------------------------
Fix Version/s: 2.0.1
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Fix For: 2.0.1
>
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-803) Configuring interceptors using
annotations
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514937 ]
Jeff Yu commented on CXF-803:
-----------------------------
As I looked at Xfire InHandlers and OutHandlers, they are very simple, it just looks up the annotation on the ServiceBean class. (possiblily I might be wrong here) Here I have some questions:
1. Do we just need to implement it as simple as what Xfire does? say, we just need to look up the annotation in the ServiceBean class.
2. If we also support this annotation in the SEI, what if both SEI and implementor specify this annotation, say which one has high priority? what is the correct search order? In fact, I think in most of cases, people would like to have this in the implementor instead of SEI.
3. I think for the CXF, we should also support InFaultInterceptor, OutFaultInterceptor annotation.
Zarar, from the maillist, you said you were writing something similiar stuff, have you started working on this JIRA, if not, I think I can pick it up..
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Jeff.Yu" <je...@iona.com>.
ok... got it, thanks for your clarification.
Thanks
Jeff
Daniel Kulp wrote:
> Jeff,
>
> He was just commenting that you spelled INTERCEPTOR wrong.... In your
> original patch, it was INTERCEPOTR (check the last three letters).
> The comment doesn't apply since you changed it.
>
> Dan
>
>
> On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
>
>> Hi, Glen
>>
>> What do you mean by changing constant from
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
>> in the initializeAnnotationObjects() method, it might be
>> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
>> etc, and I don't think we need to specify it so detail within a quite
>> generic method. BTW, I changed the
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
>> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
>> FEATURES not INTERCEPTOR.
>>
>>
>>
>> Thanks
>> Jeff Yu
>>
>> Glen Mazza (JIRA) wrote:
>>
>>> [
>>> https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
>>> a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
>>>
>>> Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
>>> ---------------------------------------------------------
>>>
>>> Looks good! But will the committer of this patch please fix the
>>> constant in initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>
>>> was:
>>> Looks good! But please fix the constant in
>>> initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>> Configuring interceptors using annotations
>>>> ------------------------------------------
>>>>
>>>> Key: CXF-803
>>>> URL: https://issues.apache.org/jira/browse/CXF-803
>>>> Project: CXF
>>>> Issue Type: New Feature
>>>> Components: Configuration
>>>> Affects Versions: 2.0
>>>> Environment: All
>>>> Reporter: Zarar Siddiqi
>>>> Attachments: cxf-803-2.patch, cxf-803.patch
>>>>
>>>>
>>>> It would be helpful to configure interceptors using annotations.
>>>> CXF would benefit by having annotations similar to XFire's
>>>> org.codehaus.xfire.annotations.InHandlers and
>>>> org.codehaus.xfire.annotations.OutHandlers as it would allow
>>>> specifying specific interceptors for service implementations. This
>>>> issue came up on the mailing list:
>>>> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
>>>> 4097300.html Thanks,
>>>> Zarar
>>>>
>
>
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Jeff.Yu" <je...@iona.com>.
ok... got it, thanks for your clarification.
Thanks
Jeff
Daniel Kulp wrote:
> Jeff,
>
> He was just commenting that you spelled INTERCEPTOR wrong.... In your
> original patch, it was INTERCEPOTR (check the last three letters).
> The comment doesn't apply since you changed it.
>
> Dan
>
>
> On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
>
>> Hi, Glen
>>
>> What do you mean by changing constant from
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
>> in the initializeAnnotationObjects() method, it might be
>> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
>> etc, and I don't think we need to specify it so detail within a quite
>> generic method. BTW, I changed the
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
>> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
>> FEATURES not INTERCEPTOR.
>>
>>
>>
>> Thanks
>> Jeff Yu
>>
>> Glen Mazza (JIRA) wrote:
>>
>>> [
>>> https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
>>> a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
>>>
>>> Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
>>> ---------------------------------------------------------
>>>
>>> Looks good! But will the committer of this patch please fix the
>>> constant in initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>
>>> was:
>>> Looks good! But please fix the constant in
>>> initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>> Configuring interceptors using annotations
>>>> ------------------------------------------
>>>>
>>>> Key: CXF-803
>>>> URL: https://issues.apache.org/jira/browse/CXF-803
>>>> Project: CXF
>>>> Issue Type: New Feature
>>>> Components: Configuration
>>>> Affects Versions: 2.0
>>>> Environment: All
>>>> Reporter: Zarar Siddiqi
>>>> Attachments: cxf-803-2.patch, cxf-803.patch
>>>>
>>>>
>>>> It would be helpful to configure interceptors using annotations.
>>>> CXF would benefit by having annotations similar to XFire's
>>>> org.codehaus.xfire.annotations.InHandlers and
>>>> org.codehaus.xfire.annotations.OutHandlers as it would allow
>>>> specifying specific interceptors for service implementations. This
>>>> issue came up on the mailing list:
>>>> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
>>>> 4097300.html Thanks,
>>>> Zarar
>>>>
>
>
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors using annotations
Posted by Daniel Kulp <dk...@apache.org>.
Jeff,
He was just commenting that you spelled INTERCEPTOR wrong.... In your
original patch, it was INTERCEPOTR (check the last three letters).
The comment doesn't apply since you changed it.
Dan
On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
> Hi, Glen
>
> What do you mean by changing constant from
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
> in the initializeAnnotationObjects() method, it might be
> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
> etc, and I don't think we need to specify it so detail within a quite
> generic method. BTW, I changed the
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
> FEATURES not INTERCEPTOR.
>
>
>
> Thanks
> Jeff Yu
>
> Glen Mazza (JIRA) wrote:
> > [
> > https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
> >a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
> >
> > Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
> > ---------------------------------------------------------
> >
> > Looks good! But will the committer of this patch please fix the
> > constant in initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >
> >
> > was:
> > Looks good! But please fix the constant in
> > initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >> Configuring interceptors using annotations
> >> ------------------------------------------
> >>
> >> Key: CXF-803
> >> URL: https://issues.apache.org/jira/browse/CXF-803
> >> Project: CXF
> >> Issue Type: New Feature
> >> Components: Configuration
> >> Affects Versions: 2.0
> >> Environment: All
> >> Reporter: Zarar Siddiqi
> >> Attachments: cxf-803-2.patch, cxf-803.patch
> >>
> >>
> >> It would be helpful to configure interceptors using annotations.
> >> CXF would benefit by having annotations similar to XFire's
> >> org.codehaus.xfire.annotations.InHandlers and
> >> org.codehaus.xfire.annotations.OutHandlers as it would allow
> >> specifying specific interceptors for service implementations. This
> >> issue came up on the mailing list:
> >> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
> >>4097300.html Thanks,
> >> Zarar
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors using annotations
Posted by Daniel Kulp <dk...@apache.org>.
Jeff,
He was just commenting that you spelled INTERCEPTOR wrong.... In your
original patch, it was INTERCEPOTR (check the last three letters).
The comment doesn't apply since you changed it.
Dan
On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
> Hi, Glen
>
> What do you mean by changing constant from
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
> in the initializeAnnotationObjects() method, it might be
> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
> etc, and I don't think we need to specify it so detail within a quite
> generic method. BTW, I changed the
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
> FEATURES not INTERCEPTOR.
>
>
>
> Thanks
> Jeff Yu
>
> Glen Mazza (JIRA) wrote:
> > [
> > https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
> >a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
> >
> > Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
> > ---------------------------------------------------------
> >
> > Looks good! But will the committer of this patch please fix the
> > constant in initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >
> >
> > was:
> > Looks good! But please fix the constant in
> > initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >> Configuring interceptors using annotations
> >> ------------------------------------------
> >>
> >> Key: CXF-803
> >> URL: https://issues.apache.org/jira/browse/CXF-803
> >> Project: CXF
> >> Issue Type: New Feature
> >> Components: Configuration
> >> Affects Versions: 2.0
> >> Environment: All
> >> Reporter: Zarar Siddiqi
> >> Attachments: cxf-803-2.patch, cxf-803.patch
> >>
> >>
> >> It would be helpful to configure interceptors using annotations.
> >> CXF would benefit by having annotations similar to XFire's
> >> org.codehaus.xfire.annotations.InHandlers and
> >> org.codehaus.xfire.annotations.OutHandlers as it would allow
> >> specifying specific interceptors for service implementations. This
> >> issue came up on the mailing list:
> >> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
> >>4097300.html Thanks,
> >> Zarar
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Jeff.Yu" <je...@iona.com>.
Hi, Glen
What do you mean by changing constant from
COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because in
the initializeAnnotationObjects() method, it might be "InInterceptor,
OutInterceptor,InFaultInterceptor, AbstractFeature" etc, and I don't
think we need to specify it so detail within a quite generic method.
BTW, I changed the COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
FEATURES not INTERCEPTOR.
Thanks
Jeff Yu
Glen Mazza (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
>
> Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
> ---------------------------------------------------------
>
> Looks good! But will the committer of this patch please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>
> Glen
>
>
>
> was:
> Looks good! But please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>
> Glen
>
>
>
>> Configuring interceptors using annotations
>> ------------------------------------------
>>
>> Key: CXF-803
>> URL: https://issues.apache.org/jira/browse/CXF-803
>> Project: CXF
>> Issue Type: New Feature
>> Components: Configuration
>> Affects Versions: 2.0
>> Environment: All
>> Reporter: Zarar Siddiqi
>> Attachments: cxf-803-2.patch, cxf-803.patch
>>
>>
>> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
>> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
>> Thanks,
>> Zarar
>>
>
>
[jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
---------------------------------------------------------
Looks good! But will the committer of this patch please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
Glen
was:
Looks good! But please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
Glen
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-803) Configuring interceptors using
annotations
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Yu updated CXF-803:
------------------------
Attachment: cxf-803.patch
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-803) Configuring interceptors using
annotations
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Yu updated CXF-803:
------------------------
Attachment: (was: cxf-803.patch)
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-803) Configuring interceptors using
annotations
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
Glen Mazza commented on CXF-803:
--------------------------------
Looks good! But please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
Glen
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.