You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/15 12:23:15 UTC
[GitHub] [hadoop-ozone] lamber-ken opened a new pull request #1426: HDDS-4247. Fixed log4j usage in some places
lamber-ken opened a new pull request #1426:
URL: https://github.com/apache/hadoop-ozone/pull/1426
## What changes were proposed in this pull request?
Fixed log4j usage in some places.
Examples, `{}` is redundant.
```
LOG.error("Error while scrubbing pipelines {}", e);
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-4247
## How was this patch tested?
not need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1426: HDDS-4247. Fixed log4j usage in some places
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1426:
URL: https://github.com/apache/hadoop-ozone/pull/1426#issuecomment-694447182
Thanks @lamber-ken for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1426: HDDS-4247. Fixed log4j usage in some places
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1426:
URL: https://github.com/apache/hadoop-ozone/pull/1426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] lamber-ken commented on a change in pull request #1426: HDDS-4247. Fixed log4j usage in some places
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1426:
URL: https://github.com/apache/hadoop-ozone/pull/1426#discussion_r489849456
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
##########
@@ -600,7 +600,7 @@ public void run() {
}
} catch (InterruptedException ie) {
- LOG.error("ExpiredTokenRemover received {}", ie);
+ LOG.error("ExpiredTokenRemover received.", ie);
Review comment:
@adoroszlai done, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1426: HDDS-4247. Fixed log4j usage in some places
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1426:
URL: https://github.com/apache/hadoop-ozone/pull/1426#discussion_r489623364
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
##########
@@ -600,7 +600,7 @@ public void run() {
}
} catch (InterruptedException ie) {
- LOG.error("ExpiredTokenRemover received {}", ie);
+ LOG.error("ExpiredTokenRemover received.", ie);
Review comment:
```suggestion
LOG.info("ExpiredTokenRemover was interrupted.", ie);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org