You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by "Rajat Khandelwal (JIRA)" <ji...@apache.org> on 2015/05/07 07:31:59 UTC
[jira] [Updated] (LENS-256) lens-cli should not use single
parameter for two values
[ https://issues.apache.org/jira/browse/LENS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajat Khandelwal updated LENS-256:
----------------------------------
Attachment: rb33392.patch
Taking patch from review board
> lens-cli should not use single parameter for two values
> -------------------------------------------------------
>
> Key: LENS-256
> URL: https://issues.apache.org/jira/browse/LENS-256
> Project: Apache Lens
> Issue Type: Improvement
> Components: client
> Reporter: Amareshwari Sriramadasu
> Assignee: Rajat Khandelwal
> Fix For: 2.2
>
> Attachments: rb33392.patch
>
>
> We have code like the following in many places in cli :
> {noformat}
> @CliCommand(value = "update storage", help = "update storage")
> public String updateStorage(
> @CliOption(key = { "", "storage" }, mandatory = true, help = "<storage-name> <path to storage-spec>") String specPair) {
> Iterable<String> parts = Splitter.on(' ').trimResults().omitEmptyStrings().split(specPair);
> {noformat}
> It should take separate parameters for each value than doing split on space
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)