You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl@perl.apache.org by Sergey Skvortsov <sk...@protey.ru> on 2006/06/13 10:58:50 UTC

[mp2] bug report - incorrect @ARGV split in xs/APR/APR/Makefile.PL

1. Problem Description:

The next line in xs/APR/APR/Makefile.PL:

%args = map { split /=/, $_ } @ARGV;

is incorrect because splits all occurencies of '=' sumbol,
while only first one must be catched.

To reproduce error just build mod_perl2 with:
CFLAGS=	-O2 -pipe -march=pentium4

Solution:

--- xs/APR/APR/Makefile.PL.orig	Tue Jun 13 08:44:02 2006
+++ xs/APR/APR/Makefile.PL	Tue Jun 13 08:45:10 2006
@@ -15,7 +15,7 @@

 my %args;

-%args = map { split /=/, $_ } @ARGV;
+%args = map { /^([^=]+)=(.*)$/; ($1, $2) } @ARGV;

 $args{NAME}         = 'APR';
 $args{VERSION_FROM} = 'APR.pm';

2. Used Components and their Configuration:

*** mod_perl version 2.000003

*** using /usr/local/lib/perl5/site_perl/5.8.8/mach/Apache2/BuildConfig.pm

*** Makefile.PL options:
  MP_APR_LIB     => aprext
  MP_APXS        => /usr/local/sbin/apxs
  MP_CCOPTS      => -DMP_IOBUFSIZE=8192
  MP_COMPAT_1X   => 0
  MP_GENERATE_XS => 1
  MP_LIBNAME     => mod_perl
  MP_USE_DSO     => 1

-- 
Sergey Skvortsov
mailto: skv@protey.ru