[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #275: Fix iceberg-spark-runtime transitive dependencies.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #275: Fix iceberg-spark-runtime transitive dependencies.
URL: https://github.com/apache/incubator-iceberg/pull/275#discussion_r302646128
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -403,10 +399,13 @@ project(':iceberg-spark-runtime') {
   }
 
   dependencies {
-    compile project(':iceberg-spark')
+    compileOnly project(':iceberg-spark')
   }
 
   shadowJar {
+    // shade compileOnly dependencies to avoid including in transitive dependencies
+    configurations = [project.configurations.compileOnly]
 
 Review comment:
   `compileOnly` dependencies are not added to artifacts. Using that for the dependencies that we shade makes sense because all of the shaded dependencies should not be listed as dependencies of the shaded Jar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org