You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/09 19:35:19 UTC

[GitHub] [flink] rionmonster commented on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

rionmonster commented on pull request #17061:
URL: https://github.com/apache/flink/pull/17061#issuecomment-939351275


   @fapaul / @AHeise 
   
   Thanks both for the feedback. I've gone ahead and closed the previous ticket and will abandon this pull request after hearing from one/both of you. I've gone ahead and created [this JIRA](https://issues.apache.org/jira/browse/FLINK-24493) to track that work - if one of you are capable of assigning that to me, I'd appreciate it and will start working on it when I have some time.
   
   Additionally, I'm in agreement on the `DemultiplexingSink` as far as naming goes. And I'm probably leaning towards a similar approach to the one in this pull request (i.e. a generic `DemultiplexingSink` and a router interface that would support all of the various routing and configuration using the new SinkFunction interface).
   
   Any additional thoughts or brain-cells towards that would be appreciated!
   
   Thanks,
   
   Rion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org