[GitHub] sergeykolychev commented on a change in pull request #13697: [MKLDNN] Enable signed int8 support for convolution.

[GitBox <gi...@apache.org>]

sergeykolychev commented on a change in pull request #13697: [MKLDNN] Enable signed int8 support for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#discussion_r243388983
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -1833,10 +1832,12 @@ MXNET_DLL int MXExecutorGetOptimizedSymbol(ExecutorHandle handle,
 
 /*!
  * \brief set a call back to notify the completion of operation
+ * \param monitor_all If true, monitor both input and output, otherwise monitor output only.
  */
 MXNET_DLL int MXExecutorSetMonitorCallback(ExecutorHandle handle,
                                            ExecutorMonitorCallback callback,
-                                           void* callback_handle);
+                                           void* callback_handle,
+                                           bool monitor_all);
 
 Review comment:
   Usually when API is changed, we usually add Ex function with the new signature.
   Other way that will not break the languages apis is to have a default value for the new bool. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services