You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/03/22 22:02:00 UTC
[jira] [Commented] (AMQNET-831) Allow extra AckTypes when using IndividualAcknowledge
[ https://issues.apache.org/jira/browse/AMQNET-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703808#comment-17703808 ]
ASF subversion and git services commented on AMQNET-831:
--------------------------------------------------------
Commit cccd4ee2efb7fa669f04b43cfb3c386a40a3a380 in activemq-nms-amqp's branch refs/heads/main from Jef Willems
[ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=cccd4ee ]
AMQNET-831 allow acktype modified_failed (#86)
* AMQNET-831 allow more acktypes
* AMQNET-831 : add tests & rejected outcome
Signed-off-by: Jefwillems <je...@gmail.com>
* AMQNET-831 : refactor tests to resolve issues
Signed-off-by: Jefwillems <je...@gmail.com>
* AMQNET-831 : remove unused code
Signed-off-by: Jefwillems <je...@gmail.com>
---------
Signed-off-by: Jefwillems <je...@gmail.com>
> Allow extra AckTypes when using IndividualAcknowledge
> -----------------------------------------------------
>
> Key: AMQNET-831
> URL: https://issues.apache.org/jira/browse/AMQNET-831
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ, AMQP, NMS
> Affects Versions: AMQP-2.0.0
> Environment: Tested with apache artemis (from the latest image on quay.io/artemiscloud/activemq-artemis-broker)
> Reporter: Jef Willems
> Priority: Major
> Labels: features, pull-request-available
> Original Estimate: 24h
> Time Spent: 40m
> Remaining Estimate: 23h 20m
>
> I wrote a pull request to allow acknowledging messages with different AckType's
> When using individual acknowledgement, the current setup only accepts MODIFIED_FAILED_UNDELIVERABLE as a negative ack, the pull request allows to use MODIFIED_FAILED, REJECTED as ack types. This way the client can automatically use broker redelivery configurations.
> The client library also is more in line with the qpid-jms counterpart when implementing this change: [https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L323]
>
> The pull request can be found here: https://github.com/apache/activemq-nms-amqp/pull/86
--
This message was sent by Atlassian Jira
(v8.20.10#820010)