[GitHub] [flink] zentol commented on a change in pull request #11587: [FLINK-14126][test] Ensure elasticsearch version check

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #11587: [FLINK-14126][test] Ensure elasticsearch version check
URL: https://github.com/apache/flink/pull/11587#discussion_r402827772
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh
 ##########
 @@ -26,7 +26,7 @@ function setup_elasticsearch {
     mkdir -p $TEST_DATA_DIR
 
     local downloadUrl=$1
-    local elasticsearch_version=${2-0}
+    local elasticsearch_version=$2
 
 Review comment:
   To make sure the value is actually set:
   
   ```suggestion
       local elasticsearch_version=$2
   
       if [ -z $elasticsearch_version ]; then
         echo "Elasticsearch version not declared."
         exit 1
       fi
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services