You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 03:30:11 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
mattisonchao opened a new pull request, #17387:
URL: https://github.com/apache/pulsar/pull/17387
### Motivation
<img width="938" alt="image" src="https://user-images.githubusercontent.com/74767115/187825625-cfbe0b87-5e4e-4f7d-91fb-ac08135c1886.png">
This problem may be caused by #16605.
### Modifications
- Fix `ClassCastException`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961231092
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
Maybe we can change the test group in another PR.
@lhotari If we can't reproduce the problem, it seems it's hard to judge whether the test is flaky or not, maybe the flaky problem was fixed in some PRs. I think we need to find a way to observe the failed frequency of the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao merged pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
mattisonchao merged PR #17387:
URL: https://github.com/apache/pulsar/pull/17387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r960302577
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
Was this added in #16605? before taking tests out of quarantine, it should be ensured that the test is not flaky any more. The problem fixed in this PR isn't about flakiness. Have you verified that ClientDeduplicationFailureTest is no more flaky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961231092
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
Maybe we can change the test group in another PR.
@lhotari I think it's hard to judge whether the test is flaky or not, maybe the flaky problem was fixed in some PRs. I think we need to find a way to observe the failed frequency of the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961241060
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
Thanks, @mattisonchao, in fact, if we can't reproduce the problem, it seems it's hard to judge whether the test is flaky or not, maybe run hundreds of times, and the problem presents a few times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#issuecomment-1233724788
@mattisonchao Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r960338693
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
How to verify? Do we have any rules for leaving the flaky test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961231092
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
Maybe we can change the test group in another PR.
@lhotari It seems it's hard to judge whether the test is flaky or not, maybe the flaky problem was fixed in some PRs. I think we need to find a way to observe the failed frequency of the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#issuecomment-1235000804
Done. Please review again @lhotari @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961231092
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
Maybe we can change the test group in another PR.
@lhotari I think it's hard to judge whether the test is flaky or not, maybe the flaky problem was fixed in some PRs. Maybe we need to find a way to observe the failed frequency of the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r960338693
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
How to verify? Do we have any rules for leaving the flaky test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961237403
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
We can discuss it in another thread. I will roll back the test group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r961237512
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
import org.testng.annotations.Test;
@Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")
Review Comment:
```suggestion
@Test(groups = "quarantine")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org