[GitHub] [iceberg] kbendick opened a new pull request #1252: Add in missing Override annotations according to Error Prone

[GitBox <gi...@apache.org>]

kbendick opened a new pull request #1252:
URL: https://github.com/apache/iceberg/pull/1252


   This adds in the missing Override annotations according to Error Prone when running `./gradlew clean && ./gradlew build`.
   
   There are still a few Error Prone errors that I'd like to fix, but I'm wondering if we'd like to possibly add an additional blocking check for specific error prone warnings / errors. These missing override annotations are relatively benign, but some of the other warnings include potentially lossy conversions as well as one try-catch-finally block where an exception is thrown in the finally block that's entirely swallowed (on closing a metadata writer I believe it was).
   
   This is likely something that could be configured with with the other checks of the CI build system and test runner. Alternatively we could use a Github action in order to reduce the amount of CPU time dedicated to each PR in the test runner system (I think it's Travis but I'd have to double check as this is only my 2nd or 3rd PR).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org