[GitHub] [iceberg] snazy commented on a change in pull request #4055: Bump Nessie from 0.18.0 to 0.19.0

[GitBox <gi...@apache.org>]

snazy commented on a change in pull request #4055:
URL: https://github.com/apache/iceberg/pull/4055#discussion_r801968557



##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -102,9 +104,9 @@ private void resetData() throws NessieConflictException, NessieNotFoundException
   }
 
   @BeforeEach
-  public void beforeEach() throws IOException {
-    uri = server.getURI().toString();
-    this.api = HttpClientBuilder.builder().withUri(uri).build(NessieApiV1.class);
+  public void beforeEach(@NessieUri URI nessieUri) throws IOException {

Review comment:
       That was part of some refactoring for the test-related code, actually: make Jersey correctly expose the "right" base URI, as there was a bug when multiple tests using that Jersey-based code ran concurrently.
   Previously there was a getter-method on the "server" class, but that became a parameter being filled from the JUnit5 extension (hence the `@NessieUri` annotation).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org