You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/08 17:57:04 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #11962: fix: Add confirmation modal on changing dataset in explore
codecov-io commented on pull request #11962:
URL: https://github.com/apache/incubator-superset/pull/11962#issuecomment-740801354
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=h1) Report
> Merging [#11962](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=desc) (ef7a8d9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.02%`.
> The diff coverage is `96.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11962 +/- ##
==========================================
- Coverage 67.70% 64.67% -3.03%
==========================================
Files 938 465 -473
Lines 45437 29054 -16383
Branches 4358 0 -4358
==========================================
- Hits 30761 18791 -11970
+ Misses 14573 10263 -4310
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.67% <96.42%> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `75.17% <0.00%> (-1.19%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | | |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/11962/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=footer). Last update [fbb458f...ef7a8d9](https://codecov.io/gh/apache/incubator-superset/pull/11962?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org