You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marcus Eriksson (JIRA)" <ji...@apache.org> on 2019/03/20 09:34:00 UTC
[jira] [Comment Edited] (CASSANDRA-15058) Avoid double counting
read latencies for digest queries
[ https://issues.apache.org/jira/browse/CASSANDRA-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796953#comment-16796953 ]
Marcus Eriksson edited comment on CASSANDRA-15058 at 3/20/19 9:33 AM:
----------------------------------------------------------------------
attaching patch to not close the iterator after digesting it;
[15058-3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...krummas:marcuse/15058-3.0]
[15058-3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...krummas:marcuse/15058-3.11]
[15058-trunk|https://github.com/apache/cassandra/compare/cassandra-trunk...krummas:marcuse/15058-trunk]
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-3.0
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-3.11
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-trunk
was (Author: krummas):
attaching patch to not close the iterator after digesting it;
https://github.com/krummas/cassandra/commits/marcuse/15058-3.0
https://github.com/krummas/cassandra/commits/marcuse/15058-3.11
https://github.com/krummas/cassandra/commits/marcuse/15058-trunk
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-3.0
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-3.11
https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15058-trunk
> Avoid double counting read latencies for digest queries
> -------------------------------------------------------
>
> Key: CASSANDRA-15058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15058
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> We are closing the {{UnfilteredPartitionIterator}} wrapped with {{withMetricsRecording}} twice when we get digest requests - closing it calls {{onClose}} and that makes the metrics update twice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org