You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jonathan Natkins (JIRA)" <ji...@apache.org> on 2014/07/22 00:04:39 UTC

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

    [ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069394#comment-14069394 ] 

Jonathan Natkins commented on KAFKA-1420:
-----------------------------------------

I was starting to work on this JIRA, but I'm hitting a small stumbling block. I've noticed some tests that create brokers using TestUtils.createBrokerConfigs() and mapping over the configs with TestUtils.createServer(), and other tests that create brokers using TestUtils.createBrokersInZk().

Where this becomes a little confusing is that both implementations of createTopic require a Seq[KafkaServer], but createServer() returns a KafkaServer via a Properties object and createBrokersInZk returns a Seq[Broker], and I don't see a particularly obvious way to go from a Broker to a KakfaServer.

Am I missing something obvious?

> Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1420
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1420
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>              Labels: newbie
>             Fix For: 0.8.2
>
>
> This is a follow-up JIRA from KAFKA-1389



--
This message was sent by Atlassian JIRA
(v6.2#6252)