You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/06/26 17:54:03 UTC

[GitHub] [incubator-mxnet] access2rohit commented on issue #15360: Revert default return type for indices in argsort() and topk() to fp32

access2rohit commented on issue #15360: Revert default return type for indices in argsort() and topk() to fp32
URL: https://github.com/apache/incubator-mxnet/pull/15360#issuecomment-505979970
 
 
   @marcoabreu the test was actually there to check for default behavior. I changed that test in my previous PR(since I was changing default behavior, a breaking change). That's why I am reverting my changes back to previous default behavior. Do you still think I need to add more cases ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services