You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/19 10:49:40 UTC
[GitHub] [netbeans] DevCharly opened a new pull request #2035:
[NETBEANS-3957] fixed "opened documents list" show HTML code instead of
rich text
DevCharly opened a new pull request #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035
https://issues.apache.org/jira/browse/NETBEANS-3957
tested with FlatLaf light/dark, Windows, Nimbus and Metal LaFs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on issue #2035: [NETBEANS-3957]
fixed "opened documents list" show HTML code instead of rich text
Posted by GitBox <gi...@apache.org>.
DevCharly commented on issue #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#issuecomment-601342178
I can now confirm that the problem is caused by PR https://github.com/apache/netbeans/pull/1990
When I checkout the commit before PR 1990 was merged (and compile the "UI Utilities API" project) it works fine.
When I checkout the commit where PR 1990 was merged it shows HTML text.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead
of rich text
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#discussion_r394976315
##########
File path: platform/o.n.swing.tabcontrol/src/org/netbeans/swing/popupswitcher/SwitcherTable.java
##########
@@ -161,7 +161,7 @@ public Component prepareRenderer(
if (ren instanceof JLabel) {
// #199007: Swing HTML renderer does a poor job of truncating long labels
JLabel prototype = (JLabel) ren;
- lbl = HtmlRenderer.createLabel();
+ lbl = (JLabel) HtmlRenderer.createRenderer();
Review comment:
I think this could be improved if lbl would be declared to be a `JComponent`. Most calls will still work, and the cases where that is not the case (calls to setIcon/setText) are already null protected and could just as well be protected with `if lbl instanceof JLabel)` and only cast at that point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead
of rich text
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#discussion_r395285365
##########
File path: platform/o.n.swing.tabcontrol/src/org/netbeans/swing/popupswitcher/SwitcherTable.java
##########
@@ -161,7 +161,7 @@ public Component prepareRenderer(
if (ren instanceof JLabel) {
// #199007: Swing HTML renderer does a poor job of truncating long labels
JLabel prototype = (JLabel) ren;
- lbl = HtmlRenderer.createLabel();
+ lbl = (JLabel) HtmlRenderer.createRenderer();
Review comment:
Ignore this - it is not cleaner, the return of `HtmlRenderer#createRenderer` does not allow this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on issue #2035:
[NETBEANS-3957] fixed "opened documents list" show HTML code instead of
rich text
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on issue #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#issuecomment-601316385
Can you give instructions for reproduction? I tested on windows with Nimbus LAF:
```
Product Version: Apache NetBeans IDE DEV (Build dev-96c12bc480bb621f05e40978fced87f99768873f)
Java: 13.0.2; OpenJDK 64-Bit Server VM 13.0.2+8
Runtime: OpenJDK Runtime Environment 13.0.2+8
```
```
Product Version: Apache NetBeans IDE DEV (Build dev-96c12bc480bb621f05e40978fced87f99768873f)
Java: 1.8.0_232; OpenJDK 64-Bit Server VM 25.232-b09
Runtime: OpenJDK Runtime Environment 1.8.0_232-b09
```
and did not see the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #2035: [NETBEANS-3957]
fixed "opened documents list" show HTML code instead of rich text
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2035:
[NETBEANS-3957] fixed "opened documents list" show HTML code instead of
rich text
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#issuecomment-601390540
@ebarboni please check if you agree, that this is good to be merged to master+12.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on issue #2035: [NETBEANS-3957]
fixed "opened documents list" show HTML code instead of rich text
Posted by GitBox <gi...@apache.org>.
DevCharly commented on issue #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#issuecomment-601326456
You have to enable "Sort opened documents list by project" checkbox in "Options > Appearance > Document Tabs" (at the bottom).
Then the documents popup (down arrow at right side of editor tabs) includes project names (in bold):
If you move the mouse over a project name it changes from bold text to HTML text.
There are more screenshots in the JIRA issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2035:
[NETBEANS-3957] fixed "opened documents list" show HTML code instead of
rich text
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2035: [NETBEANS-3957] fixed "opened documents list" show HTML code instead of rich text
URL: https://github.com/apache/netbeans/pull/2035#issuecomment-601316385
Can you give instructions for reproduction? I tested on windows Nimbus LAF was tested on:
```
Product Version: Apache NetBeans IDE DEV (Build dev-96c12bc480bb621f05e40978fced87f99768873f)
Java: 13.0.2; OpenJDK 64-Bit Server VM 13.0.2+8
Runtime: OpenJDK Runtime Environment 13.0.2+8
```
```
Product Version: Apache NetBeans IDE DEV (Build dev-96c12bc480bb621f05e40978fced87f99768873f)
Java: 1.8.0_232; OpenJDK 64-Bit Server VM 25.232-b09
Runtime: OpenJDK Runtime Environment 1.8.0_232-b09
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists