You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2017/12/19 22:41:01 UTC
[GitHub] activemq-artemis pull request #1733: ARTEMIS-1545 Support JMS 2.0 Completion...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1733
ARTEMIS-1545 Support JMS 2.0 Completion Listener for Exceptions
@clebertsuconic re-sending so we can work through
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1545-DEC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1733.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1733
----
commit d214e8acc17214d0d7024e4bdc41193b35499782
Author: Michael André Pearce <mi...@...>
Date: 2017-12-14T07:47:30Z
ARTEMIS-1545 Support JMS 2.0 Completion Listener for Exceptions
----
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
I saw it also on the journal one as well.
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@michaelandrepearce I promise I will get here by next week :)
---
[GitHub] activemq-artemis issue #1733: ARTEMIS-1545 Support JMS 2.0 Completion Listen...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@clebertsuconic https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/4660/ full test suite passed, what issue did you see?
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@michaelandrepearce the error you saw was a LargeMessage test dead locking under JDBC for no apparent connected reason?
if that's the case.. I am working on it now. just confirm please?
---
[GitHub] activemq-artemis issue #1733: ARTEMIS-1545 Support JMS 2.0 Completion Listen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
The Pr build is not the full the testsuite.
I ran mvn test -Ptests
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
.. just to say I'm working on it.. getting my head and debugging it..
---
[GitHub] activemq-artemis issue #1733: ARTEMIS-1545 Support JMS 2.0 Completion Listen...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
Still being worked on, don't merge.
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@clebertsuconic did you get a chance to possibly look at whats missing / why those extra tests don't pass with this change, im still struggling to figure it myself
---
[GitHub] activemq-artemis issue #1733: ARTEMIS-1545 Support JMS 2.0 Completion Listen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
The full testsuite is stale on this...
On my personal CI box, when I run the following grep:
http://my-ci-box:8080/view/Artemis/job/novm-artemis-param/2294/consoleText
```
curl -s --insecure -0 http://my-ci-box:8080/view/Artemis/job/novm-artemis-param/2294/consoleText | grep -a -e "222105" -e Running -e "Tests run" -e "Finished Test" -e "Run test" -e "Start test" -e "Stop test"
```
I see the following:
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.103 sec - in org.apache.activemq.artemis.tests.integration.client.JMSMessageCounterTest
Running org.apache.activemq.artemis.tests.integration.client.JMSPagingFileDeleteTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.121 sec <<< FAILURE! - in org.apache.activemq.artemis.tests.integration.client.JMSPagingFileDeleteTest
Running org.apache.activemq.artemis.tests.integration.client.JmsNettyNioStressTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.205 sec - in org.apache.activemq.artemis.tests.integration.client.JmsNettyNioStressTest
Running org.apache.activemq.artemis.tests.integration.client.JournalCrashTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.646 sec - in org.apache.activemq.artemis.tests.integration.client.JournalCrashTest
Running org.apache.activemq.artemis.tests.integration.client.LargeMessageAvoidLargeMessagesTest
``
---
[GitHub] activemq-artemis issue #1733: ARTEMIS-1545 Support JMS 2.0 Completion Listen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@michaelandrepearce it hangs on that test.. never finish.. freezes on that last test.
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@michaelandrepearce I rebased and I'm running tests to get a current status..
---
[GitHub] activemq-artemis pull request #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1733
---
[GitHub] activemq-artemis issue #1733: ARTEMIS-1545 Support JMS 2.0 Completion Listen...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@clebertsuconic sorry could you expand on what you mean by the test suite is stale on this.
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
@clebertsuconic nudge nudge wink wink.... :)
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
Closing as merged by another PR
---
[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1733
Also i can’t remember (sorry laptop is no where near me tonight taking some time out tonight) but I remember issue in Bridge test but I was concentrating on this first
---