You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/09 09:57:48 UTC

[GitHub] [flink] lincoln-lil opened a new pull request, #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

lincoln-lil opened a new pull request, #20800:
URL: https://github.com/apache/flink/pull/20800

   ## What is the purpose of the change
   FLINK-28848 introduces the new LOOKUP hint, but doesn't support table alias due to calcite's snapshot not hintable, now CALCITE-5251 has been merged(and will be included in calcite-1.32.0) , we can move on supporting alias in flink. And the copied file of snapshot relnode can be deleted when flink done upgrading of calcite-1.32.0.
   
   ## Brief change log
   * copy Snapshot node from calcite-1.26.0 and cherry-pick the hint support for it (CALCITE-5251) 
   * add alias support for LOOKUP hint and update related tests
   
   ## Verifying this change
   LookupJoinTest  LookupJoinJsonPlanTest
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #20800:
URL: https://github.com/apache/flink/pull/20800#issuecomment-1250520693

   > @flinkbot run azure
   
   failed by a known case:  https://issues.apache.org/jira/browse/FLINK-29315
   
   https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41103&view=logs&j=ab8d7049-0920-5f52-eeed-e548522c2880&t=a7d66b08-71af-51c3-2721-4b90fa4f94e3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20800:
URL: https://github.com/apache/flink/pull/20800#issuecomment-1241769968

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1667aeacfa0b7312723831ff5a7507b944ad343b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1667aeacfa0b7312723831ff5a7507b944ad343b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1667aeacfa0b7312723831ff5a7507b944ad343b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #20800:
URL: https://github.com/apache/flink/pull/20800#issuecomment-1250440721

   Succeed in pipeline: https://dev.azure.com/lincoln86xy/lincoln86xy/_build/results?buildId=304&view=results
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #20800:
URL: https://github.com/apache/flink/pull/20800#issuecomment-1366346357

   @godfreyhe thanks for reviewing this! I've updated the pr according to your comments, the Snapshot was formatted correctly in the first commit and added two more cases that use table name as hint option(previously, only one case was kept)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe closed pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint
URL: https://github.com/apache/flink/pull/20800


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #20800:
URL: https://github.com/apache/flink/pull/20800#issuecomment-1250441016

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org