You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org> on 2024/03/03 11:04:44 UTC
Re: [PR] gRPC query extension (druid)
github-advanced-security[bot] commented on code in PR #15982:
URL: https://github.com/apache/druid/pull/15982#discussion_r1510239824
##########
extensions-contrib/grpc-query/src/test/java/org/apache/druid/grpc/GrpcQueryTestClient.java:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.grpc;
+
+import org.apache.druid.grpc.proto.HealthOuterClass.HealthCheckRequest;
+import org.apache.druid.grpc.proto.HealthOuterClass.HealthCheckResponse;
+import org.apache.druid.grpc.proto.QueryOuterClass.ColumnSchema;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryRequest;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryResponse;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryResultFormat;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryStatus;
+import org.apache.druid.grpc.server.QueryServer;
+import org.apache.druid.java.util.common.StringUtils;
+
+import java.nio.charset.StandardCharsets;
+
+/**
+ * Super-simple command-line (or IDE launched) client which makes a
+ * single query request and prints
+ * the response. Useful because Druid provides no other rRPC client
+ * to use to test the rRPC endpoint. Pass the desired query as the
+ * one and only command line parameter. Does not (yet) support the
+ * query context or query parameters.
+ */
+public class GrpcQueryTestClient
+{
+ public static void main(String[] args)
+ {
+ if (args.length != 1) {
+ System.err.println("Usage: sql-query");
+ System.exit(1);
+ }
+ TestClient client = new TestClient(TestClient.DEFAULT_HOST);
+ QueryRequest request = QueryRequest.newBuilder()
+ .setQuery(args[0])
+ .setResultFormat(QueryResultFormat.CSV)
+ .build();
+ QueryResponse response = client.getQueryClient().submitQuery(request);
+
+ HealthCheckRequest healthCheckRequest = HealthCheckRequest.newBuilder()
+ .setService(QueryServer.class.getName())
+ .build();
+
+ HealthCheckResponse healthCheckResponse = client
+ .getHealthCheckClient()
+ .check(healthCheckRequest);
+
+ int x = 1;
Review Comment:
## Unread local variable
Variable 'int x' is never read.
[Show more details](https://github.com/apache/druid/security/code-scanning/6855)
##########
extensions-contrib/grpc-query/src/test/java/org/apache/druid/grpc/GrpcQueryTestClient.java:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.grpc;
+
+import org.apache.druid.grpc.proto.HealthOuterClass.HealthCheckRequest;
+import org.apache.druid.grpc.proto.HealthOuterClass.HealthCheckResponse;
+import org.apache.druid.grpc.proto.QueryOuterClass.ColumnSchema;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryRequest;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryResponse;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryResultFormat;
+import org.apache.druid.grpc.proto.QueryOuterClass.QueryStatus;
+import org.apache.druid.grpc.server.QueryServer;
+import org.apache.druid.java.util.common.StringUtils;
+
+import java.nio.charset.StandardCharsets;
+
+/**
+ * Super-simple command-line (or IDE launched) client which makes a
+ * single query request and prints
+ * the response. Useful because Druid provides no other rRPC client
+ * to use to test the rRPC endpoint. Pass the desired query as the
+ * one and only command line parameter. Does not (yet) support the
+ * query context or query parameters.
+ */
+public class GrpcQueryTestClient
+{
+ public static void main(String[] args)
+ {
+ if (args.length != 1) {
+ System.err.println("Usage: sql-query");
+ System.exit(1);
+ }
+ TestClient client = new TestClient(TestClient.DEFAULT_HOST);
+ QueryRequest request = QueryRequest.newBuilder()
+ .setQuery(args[0])
+ .setResultFormat(QueryResultFormat.CSV)
+ .build();
+ QueryResponse response = client.getQueryClient().submitQuery(request);
+
+ HealthCheckRequest healthCheckRequest = HealthCheckRequest.newBuilder()
+ .setService(QueryServer.class.getName())
+ .build();
+
+ HealthCheckResponse healthCheckResponse = client
+ .getHealthCheckClient()
+ .check(healthCheckRequest);
Review Comment:
## Unread local variable
Variable 'HealthCheckResponse healthCheckResponse' is never read.
[Show more details](https://github.com/apache/druid/security/code-scanning/6854)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org