You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "arvindp25 (via GitHub)" <gi...@apache.org> on 2025/08/06 16:40:35 UTC
[PR] fixing file extension issue [airflow]
arvindp25 opened a new pull request, #54187:
URL: https://github.com/apache/airflow/pull/54187
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #53976
related: #53976
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
Fix file extension issue while loading file to s3. now loaded file have proper extension.
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "arvindp25 (via GitHub)" <gi...@apache.org>.
arvindp25 commented on code in PR #54187:
URL: https://github.com/apache/airflow/pull/54187#discussion_r2260839607
##########
providers/amazon/tests/unit/amazon/aws/transfers/test_sql_to_s3.py:
##########
@@ -64,7 +64,7 @@ def test_execute_csv(self, mock_s3_hook, dtype_backend):
file_obj = mock_s3_hook.return_value.load_file_obj.call_args[1]["file_obj"]
assert isinstance(file_obj, io.BytesIO)
mock_s3_hook.return_value.load_file_obj.assert_called_once_with(
- file_obj=file_obj, key=s3_key, bucket_name=s3_bucket, replace=True
+ file_obj=file_obj, key=f"{s3_key}.csv", bucket_name=s3_bucket, replace=True
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #54187:
URL: https://github.com/apache/airflow/pull/54187#issuecomment-3176282572
This is going to change the user experience, but I think we can definitely catalogue this one as a bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54187:
URL: https://github.com/apache/airflow/pull/54187#discussion_r2264706970
##########
providers/amazon/tests/unit/amazon/aws/transfers/test_sql_to_s3.py:
##########
@@ -64,7 +64,7 @@ def test_execute_csv(self, mock_s3_hook, dtype_backend):
file_obj = mock_s3_hook.return_value.load_file_obj.call_args[1]["file_obj"]
assert isinstance(file_obj, io.BytesIO)
mock_s3_hook.return_value.load_file_obj.assert_called_once_with(
- file_obj=file_obj, key=s3_key, bucket_name=s3_bucket, replace=True
+ file_obj=file_obj, key=f"{s3_key}.csv", bucket_name=s3_bucket, replace=True
Review Comment:
Thanks! LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #54187:
URL: https://github.com/apache/airflow/pull/54187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #54187:
URL: https://github.com/apache/airflow/pull/54187#issuecomment-3403213341
> It's a breaking change. We named our file with .tsv Now, every file becomes .tsv.csv...
@bryanyang0528 Can you create a Github Issue with more details and reproduction steps. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "bryanyang0528 (via GitHub)" <gi...@apache.org>.
bryanyang0528 commented on PR #54187:
URL: https://github.com/apache/airflow/pull/54187#issuecomment-3397798016
It's a breaking change.
We named our file with <XXX>.tsv
Now, every file becomes <XXX>.tsv.csv...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixing file extension issue on SqlToS3Operator [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54187:
URL: https://github.com/apache/airflow/pull/54187#discussion_r2259413807
##########
providers/amazon/tests/unit/amazon/aws/transfers/test_sql_to_s3.py:
##########
@@ -64,7 +64,7 @@ def test_execute_csv(self, mock_s3_hook, dtype_backend):
file_obj = mock_s3_hook.return_value.load_file_obj.call_args[1]["file_obj"]
assert isinstance(file_obj, io.BytesIO)
mock_s3_hook.return_value.load_file_obj.assert_called_once_with(
- file_obj=file_obj, key=s3_key, bucket_name=s3_bucket, replace=True
+ file_obj=file_obj, key=f"{s3_key}.csv", bucket_name=s3_bucket, replace=True
Review Comment:
We could consider using `@pytest.mark.parametrize` to reduce code duplication and improve maintainability since lots of the test looks similar here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org