You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "François Rosière (Jira)" <ji...@apache.org> on 2022/04/30 20:41:00 UTC
[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Rosière updated KAFKA-13864:
-------------------------------------
Description:
To allow implementing Spring managed interceptors for producers and consumers,
[https://github.com/spring-projects/spring-kafka/issues/2244]
the visibility of one constructor of KafkaProducer and KafkaConsumer should move from the default modifier to the public modifier.
See
[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L321]
and
[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671]
For the KafkaProducer, it may make more sense to expose the following constructor
{code:java}
public KafkaProducer(ProducerConfig config, Serializer<K> keySerializer, Serializer<V> valueSerializer){code}
Any other alternative or proposal would be more than welcome.
Kafka streams are not concerned by this issues as the KafkaStreams object is already exposing a constructor taking a StreamsConfig object.
Thanks for considering this issue.
was:
To allow implementing Spring managed interceptors for producers and consumers,
[https://github.com/spring-projects/spring-kafka/issues/2244]
the visibility of one constructor of KafkaProducer and KafkaConsumer should move from the default modifier to the public modifier.
See
[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L321]
and
[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671]
Any other alternative or proposal would be more than welcome.
Kafka streams are not concerned by this issues as the KafkaStreams object is already exposing a constructor taking a StreamsConfig object.
Thanks for considering this issue.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> ----------------------------------------------------------------------
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 3.1.0
> Reporter: François Rosière
> Priority: Major
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> the visibility of one constructor of KafkaProducer and KafkaConsumer should move from the default modifier to the public modifier.
> See
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L321]
> and
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671]
> For the KafkaProducer, it may make more sense to expose the following constructor
>
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer<K> keySerializer, Serializer<V> valueSerializer){code}
>
> Any other alternative or proposal would be more than welcome.
> Kafka streams are not concerned by this issues as the KafkaStreams object is already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)