[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1720: [Improve] [Core] Extract the CommandArgs implement class field

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #1720:
URL: https://github.com/apache/incubator-seatunnel/pull/1720#discussion_r854780540


##########
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/command/CommandArgs.java:
##########
@@ -20,10 +20,69 @@
 import org.apache.seatunnel.common.config.DeployMode;
 import org.apache.seatunnel.config.EngineType;
 
-public interface CommandArgs {
+import com.beust.jcommander.Parameter;
 
-    EngineType getEngineType();
+import java.util.Collections;
+import java.util.List;
 
-    DeployMode getDeployMode();
+public abstract class CommandArgs {

Review Comment:
   ```suggestion
   public abstract class AbstractCommandArgs {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org