You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/10/17 14:38:36 UTC

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests

kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336044898
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
   add_compile_options(-Wno-gnu-statement-expression)
 endif()
 
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
 
 Review comment:
   Just a head's up - I'm refactoring the way we enable TSAN in cmake to follow the model used by proton. 
   See [DISPATCH-1450](https://issues.apache.org/jira/browse/DISPATCH-1450)
   
   I'll be creating a pull request for DISPATCH-1450 in the next day or so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org