You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "xlq20080808 (via GitHub)" <gi...@apache.org> on 2023/02/28 09:52:02 UTC
[GitHub] [skywalking] xlq20080808 opened a new issue, #10461: [Feature] DCS supports global configuration
xlq20080808 opened a new issue, #10461:
URL: https://github.com/apache/skywalking/issues/10461
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Add a configuration item "global-configurations" to the dynamic configuration
Global configuration has lower priority than service level "configurations"
### Use case
<img width="501" alt="image" src="https://user-images.githubusercontent.com/33999699/221816207-86fbfb14-6f01-465b-9fca-f6f7996c0489.png">
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1448090139
Notice, you should not break the existing config format. I would like to suggest the format like this
```
configurations:
// NEW added global config
key1 : value1
key2: value2
...
//service name
serviceA:
// Configurations of service A
// Key and Value are determined by the agent side.
// Check the agent setup doc for all available configurations.
key1: value1
key2: value2
...
serviceB:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447908579
And this seems a discussion only. Feature is something you are going to do, or committers planned to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1448087576
OK, if you want to do this, feel free to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xlq20080808 commented on issue #10461: [Feature] DCS supports global configuration
Posted by "xlq20080808 (via GitHub)" <gi...@apache.org>.
xlq20080808 commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447927018
If this function is valuable to skywalking community, I would like to implement it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1476209716
Ref https://github.com/apache/skywalking/pull/10476#issuecomment-1476208961
We haven't finished this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10461: [Feature] DCS supports global configuration
URL: https://github.com/apache/skywalking/issues/10461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10461: [Feature] DCS supports global configuration
URL: https://github.com/apache/skywalking/issues/10461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xlq20080808 commented on issue #10461: [Feature] DCS supports global configuration
Posted by "xlq20080808 (via GitHub)" <gi...@apache.org>.
xlq20080808 commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1448076763
sry I didn't make it clear. The document you sent is the server sampling configuration
For example, I want to dynamically modify the client sampling configuration of all servcies to 500. I need to do this:
```
configurations:
my_test_service_A:
agent. sample_ n_ per_ 3_ secs: 500
my_test_service_B:
agent. sample_ n_ per_ 3_ secs: 500
my_test_service_C:
agent. sample_ n_ per_ 3_ secs: 500
...
```
Of course, I will also change other configurations besides client sampling rate
I have many services. It is difficult for me to write them all here
so I want to increase the function of global configuration to avoid writing all service names for my global changes
such as
```
global-confiugurations:
agent. sample_ n_ per_ 3_ secs: 500
configurations:
my_test_service_A:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447907615
You seem to ask for `agent-analyzer.default.traceSamplingPolicy` only? If so, there is `default` for that already.
https://skywalking.apache.org/docs/main/next/en/setup/backend/trace-sampling/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xlq20080808 commented on issue #10461: [Feature] DCS supports global configuration
Posted by "xlq20080808 (via GitHub)" <gi...@apache.org>.
xlq20080808 commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447922341
I expect is that oap can deliver dynamic configuration to all agents,no need to configure to a single service.not just for sampling.
There is a related discussion #9967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447945481
I am confused. Do we have service specific configuration on DCS?
We don't plan to break existing configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xlq20080808 commented on issue #10461: [Feature] DCS supports global configuration
Posted by "xlq20080808 (via GitHub)" <gi...@apache.org>.
xlq20080808 commented on issue #10461:
URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1448093938
Ok I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org