You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@velocity.apache.org by cb...@apache.org on 2007/06/29 16:05:47 UTC

svn commit: r551901 - /velocity/tools/trunk/src/java/org/apache/velocity/tools/view/tools/BrowserSnifferTool.java

Author: cbrisson
Date: Fri Jun 29 07:05:46 2007
New Revision: 551901

URL: http://svn.apache.org/viewvc?view=rev&rev=551901
Log:
protect BrowserSniffer from requests without user-agent

Modified:
    velocity/tools/trunk/src/java/org/apache/velocity/tools/view/tools/BrowserSnifferTool.java

Modified: velocity/tools/trunk/src/java/org/apache/velocity/tools/view/tools/BrowserSnifferTool.java
URL: http://svn.apache.org/viewvc/velocity/tools/trunk/src/java/org/apache/velocity/tools/view/tools/BrowserSnifferTool.java?view=diff&rev=551901&r1=551900&r2=551901
==============================================================================
--- velocity/tools/trunk/src/java/org/apache/velocity/tools/view/tools/BrowserSnifferTool.java (original)
+++ velocity/tools/trunk/src/java/org/apache/velocity/tools/view/tools/BrowserSnifferTool.java Fri Jun 29 07:05:46 2007
@@ -89,7 +89,12 @@
             throw new IllegalArgumentException("Was expecting " + ViewContext.class +
                                                " or " + HttpServletRequest.class);
         }
-        userAgent = req.getHeader("User-Agent").toLowerCase();
+        userAgent = req.getHeader("User-Agent");
+        if(userAgent == null) {
+            userAgent = "";
+        } else {
+            userAgent = userAgent.toLowerCase();
+        }
     }
 
     /* Generic getter for unknown tests