You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/08 13:21:16 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
dongjoon-hyun opened a new pull request #35769:
URL: https://github.com/apache/spark/pull/35769
### What changes were proposed in this pull request?
This PR is a follow-up of #35639 to prevent `PodGroup` with `null` spec.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35769:
URL: https://github.com/apache/spark/pull/35769#issuecomment-1061773812
cc @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35769:
URL: https://github.com/apache/spark/pull/35769#discussion_r821919615
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -58,7 +60,7 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
override def configurePod(pod: SparkPod): SparkPod = {
- priorityClassName = Some(pod.pod.getSpec.getPriorityClassName)
+ priorityClassName = Option(pod.pod.getSpec.getPriorityClassName)
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35769:
URL: https://github.com/apache/spark/pull/35769#discussion_r821919419
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -48,6 +48,8 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
.withName(podGroupName)
.withNamespace(namespace)
.endMetadata()
+ .editOrNewSpec()
+ .endSpec()
queue.foreach(podGroup.editOrNewSpec().withQueue(_).endSpec())
Review comment:
there is also a `editOrNewSpec`...`endSpec`, do we need above one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35769:
URL: https://github.com/apache/spark/pull/35769#issuecomment-1062028696
cc @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35769:
URL: https://github.com/apache/spark/pull/35769#issuecomment-1062046944
Thank you, @viirya and all! Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35769: [SPARK-38423][K8S][FOLLOWUP] PodGroup spec should not be null
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35769:
URL: https://github.com/apache/spark/pull/35769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org