You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "James Strachan (JIRA)" <ji...@apache.org> on 2007/11/05 16:09:22 UTC
[jira] Created: (CAMEL-207) support a Predicate based Aggregator so
that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
-----------------------------------------------------------------------------------------------------------------------------------------------------
Key: CAMEL-207
URL: https://issues.apache.org/activemq/browse/CAMEL-207
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Reporter: James Strachan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-207) support a Predicate based Aggregator so
that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Kalukiewicz updated CAMEL-207:
------------------------------------
Attachment: aggregator3.patch
Sorry I've missed your comment.
I've just updated my sources and created this patch. I've already tested it on my source code and everything passes now (for me ;) ).
I believe previously I had not updated my sources or you had different source code and patch was applied in some wrong way..
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch, aggregation2.patch, aggregator3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40562 ]
James Strachan commented on CAMEL-207:
--------------------------------------
Discussions on this issue are here
http://www.nabble.com/splitter-aggregator-scenatio-tf4726642s22882.html
http://www.nabble.com/Aggregator-strategies-%28again%29-tf4750834s22882.html
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-207) support a Predicate based Aggregator so
that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Kalukiewicz updated CAMEL-207:
------------------------------------
Attachment: aggregation.patch
Test for aggregator scenario together with fix for a bug that was in current implementation - aggregated messages were not cleared and condition in the loop was wrong.
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Attachments: aggregation.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-207) support a Predicate based Aggregator so
that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Kalukiewicz updated CAMEL-207:
------------------------------------
Attachment: aggregation2.patch
Sorry for constantly reopening this issue but my patch partially fixed the problem. Another one shows up when you aggregate things for different correlation id's at the same time.
I hope this is the last patch for this problem - now better tested..
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch, aggregation2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan resolved CAMEL-207.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
Many thanks - patch applied!
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40626 ]
James Strachan commented on CAMEL-207:
--------------------------------------
when I apply your second patch, I get the testPredicate failing - only 5 messages received instead of 20
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch, aggregation2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40631 ]
James Strachan commented on CAMEL-207:
--------------------------------------
BTW I fixed the failing SpringAggregatorTest by using the new <methodCall bean="foo" method="whatnot"/> expression for example
{code}
<route>
<from uri="direct:predicate"/>
<aggregator strategyRef="myAggregatorStrategy">
<simple>header.cheese</simple>
<to uri="mock:result"/>
<completedPredicate>
<methodCall bean="myAggregatorStrategy" method="isCompleted"/>
</completedPredicate>
</aggregator>
</route>
{code}
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch, aggregation2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Kalukiewicz reopened CAMEL-207:
-------------------------------------
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan resolved CAMEL-207.
----------------------------------
Resolution: Fixed
Patch applied with thanks!
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch, aggregation2.patch, aggregator3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40563 ]
James Strachan commented on CAMEL-207:
--------------------------------------
an early spike implementation has been committed - try adding a Predicate to the AggregatorType or DSL; though it needs testing!
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-207) support a Predicate based Aggregator
so that rather than batch size or batch timeout, we use a predicate to
determine when an aggregator has finished
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40625 ]
James Strachan commented on CAMEL-207:
--------------------------------------
BTW I commit your previous patch without checking that the camel-spring model worked - I think your last patch broke the Spring test case...
> support a Predicate based Aggregator so that rather than batch size or batch timeout, we use a predicate to determine when an aggregator has finished
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-207
> URL: https://issues.apache.org/activemq/browse/CAMEL-207
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 1.3.0
>
> Attachments: aggregation.patch, aggregation2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.