You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Dapeng Sun <da...@intel.com> on 2016/01/29 03:24:49 UTC
Review Request 42944: SENTRY-1027: Fix PMD error for unused field when
enable Hive authz V2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42944/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1027
https://issues.apache.org/jira/browse/SENTRY-1027
Repository: sentry
Description
-------
Fix unused fields according PMD
Diffs
-----
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java 9e72b78
Diff: https://reviews.apache.org/r/42944/diff/
Testing
-------
Remove unused fields **grantorPrincipal at grantOrRevokePrivlegeOnRole** and **grantOption at grantOrRevokePrivlegeOnRole**
Thanks,
Dapeng Sun
Re: Review Request 42944: SENTRY-1027: Fix PMD error for unused field
when enable Hive authz V2
Posted by Dapeng Sun <da...@intel.com>.
> On 一月 29, 2016, 10:45 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java, line 361
> > <https://reviews.apache.org/r/42944/diff/1/?file=1225423#file1225423line361>
> >
> > The comment is also needed to be updated.
Thank Colin, I will update it on next patch.
> On 一月 29, 2016, 10:45 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java, line 481
> > <https://reviews.apache.org/r/42944/diff/1/?file=1225423#file1225423line481>
> >
> > The comment is also needed to be updated.
Thank Colin, I will update it on next patch.
- Dapeng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42944/#review116880
-----------------------------------------------------------
On 一月 29, 2016, 10:24 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42944/
> -----------------------------------------------------------
>
> (Updated 一月 29, 2016, 10:24 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1027
> https://issues.apache.org/jira/browse/SENTRY-1027
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fix unused fields according PMD
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java 9e72b78
>
> Diff: https://reviews.apache.org/r/42944/diff/
>
>
> Testing
> -------
>
> Remove unused fields **grantorPrincipal at grantOrRevokePrivlegeOnRole** and **grantOption at grantOrRevokePrivlegeOnRole**
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 42944: SENTRY-1027: Fix PMD error for unused field
when enable Hive authz V2
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42944/#review116880
-----------------------------------------------------------
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java (line 359)
<https://reviews.apache.org/r/42944/#comment177974>
The comment is also needed to be updated.
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java (line 478)
<https://reviews.apache.org/r/42944/#comment177975>
The comment is also needed to be updated.
- Colin Ma
On Jan. 29, 2016, 2:24 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42944/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 2:24 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1027
> https://issues.apache.org/jira/browse/SENTRY-1027
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fix unused fields according PMD
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java 9e72b78
>
> Diff: https://reviews.apache.org/r/42944/diff/
>
>
> Testing
> -------
>
> Remove unused fields **grantorPrincipal at grantOrRevokePrivlegeOnRole** and **grantOption at grantOrRevokePrivlegeOnRole**
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 42944: SENTRY-1027: Fix PMD error for unused field
when enable Hive authz V2
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42944/
-----------------------------------------------------------
(Updated 二月 1, 2016, 9:25 a.m.)
Review request for sentry.
Changes
-------
Update patch accroding the feedback.
Bugs: SENTRY-1027
https://issues.apache.org/jira/browse/SENTRY-1027
Repository: sentry
Description
-------
Fix unused fields according PMD
Diffs (updated)
-----
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java 9e72b78
Diff: https://reviews.apache.org/r/42944/diff/
Testing
-------
Remove unused fields **grantorPrincipal at grantOrRevokePrivlegeOnRole** and **grantOption at grantOrRevokePrivlegeOnRole**
Thanks,
Dapeng Sun