[GitHub] [ozone] rakeshadr commented on pull request #2819: HDDS-5929. Make FSO and OBS bucket layouts independent of normalization config flag

[GitBox <gi...@apache.org>]

rakeshadr commented on pull request #2819:
URL: https://github.com/apache/ozone/pull/2819#issuecomment-964818580


   @aryangupta1998 
   Test case failures are due to a special case `OMConfigKeys.OZONE_OM_ENABLE_FILESYSTEM_PATHS, true`.
   TestOzoneFSWithObjectStoreCreate and TestOzoneFileSystemMetrics.
   
   These tests expects the keyPath to be normalized but at the OM side the default bucket layout has been set to OBS layout, which won't do normalization now and resulted in failure.
   
   Please do two changes to fix the test failure:
   
   (1) Set `conf.set(OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT, BucketLayout.LEGACY.name())`; to the test case. Also, the same has to be set in the robot test cases(acceptance tests as well).
   (2) Add LEGACY to the allowed values for the ozone.default.bucket.layout config at OzoneManager.java class. @JyotinderSingh also doing this change in HDDS-5839, so we can take an incremental approach now and gradually will remove the LEGACY support in future.
   
      ```
      // Make sure defaultBucketLayout is set to a valid value
       if (!defaultBucketLayout.equals(
           BucketLayout.FILE_SYSTEM_OPTIMIZED.name()) &&
           !defaultBucketLayout.equals(BucketLayout.OBJECT_STORE.name())
       ) 
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org