You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by rh...@apache.org on 2010/09/10 19:26:23 UTC

svn commit: r995884 - in /qpid/trunk/qpid/python/qpid: messaging/endpoints.py tests/messaging/__init__.py tests/messaging/endpoints.py

Author: rhs
Date: Fri Sep 10 17:26:23 2010
New Revision: 995884

URL: http://svn.apache.org/viewvc?rev=995884&view=rev
Log:
fixed detach to not hang on session error, fixed the tests to include a timeout for connection teardown

Modified:
    qpid/trunk/qpid/python/qpid/messaging/endpoints.py
    qpid/trunk/qpid/python/qpid/tests/messaging/__init__.py
    qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py

Modified: qpid/trunk/qpid/python/qpid/messaging/endpoints.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/messaging/endpoints.py?rev=995884&r1=995883&r2=995884&view=diff
==============================================================================
--- qpid/trunk/qpid/python/qpid/messaging/endpoints.py (original)
+++ qpid/trunk/qpid/python/qpid/messaging/endpoints.py Fri Sep 10 17:26:23 2010
@@ -261,6 +261,7 @@ class Connection(Endpoint):
   def _unlinked(self):
     return [l
             for ssn in self.sessions.values()
+            if not (ssn.error or ssn.closed)
             for l in ssn.senders + ssn.receivers
             if not (l.linked or l.error or l.closed)]
 

Modified: qpid/trunk/qpid/python/qpid/tests/messaging/__init__.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/tests/messaging/__init__.py?rev=995884&r1=995883&r2=995884&view=diff
==============================================================================
--- qpid/trunk/qpid/python/qpid/tests/messaging/__init__.py (original)
+++ qpid/trunk/qpid/python/qpid/tests/messaging/__init__.py Fri Sep 10 17:26:23 2010
@@ -56,7 +56,7 @@ class Base(Test):
       self.conn = None
 
   def teardown_connection(self, conn):
-    conn.close()
+    conn.close(timeout=self.timeout())
 
   def content(self, base, count = None):
     if count is None:
@@ -159,6 +159,9 @@ class Base(Test):
   def delay(self):
     return float(self.config.defines.get("delay", "2"))
 
+  def timeout(self):
+    return float(self.config.defines.get("timeout", "60"))
+
   def get_bool(self, name):
     return self.config.defines.get(name, "false").lower() in ("true", "yes", "1")
 

Modified: qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py?rev=995884&r1=995883&r2=995884&view=diff
==============================================================================
--- qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py (original)
+++ qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py Fri Sep 10 17:26:23 2010
@@ -710,7 +710,7 @@ class ReceiverTests(Base):
 
   def fetchFromConcurrentCloseTest(self, entry):
     def closer():
-      time.sleep(self.delay())
+      self.sleep()
       entry.close()
     t = Thread(target=closer)
     t.start()



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org