You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/04/07 18:35:38 UTC
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24173
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
[rpc] add PREDICT_FALSE() for unlikely error scenarios
I was looking at the RPC code to clarify a few perf-related questions
and found that PREDICT_{TRUE,FALSE}() were not used uniformly throughout
the code. This patch adds these macros in the rest of relevant places,
where applicable.
This changelist doesn't contain any functional modifications.
Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/client_negotiation.h
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/proxy.cc
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc_controller.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/service_pool.cc
13 files changed, 47 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/24173/1
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24173 )
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
Patch Set 1: Verified+1
unrelated failures of known flaky tests:
* DEBUG: some strange failure in Python tests that's seems to be completely unrelated (need to investigate this, though)
* ASAN: Maximum unit test time exceeded in MaxInListLength/PartitionPrunerTestWithMaxInListLength.TestMultiColumnInListHashPruningManyValues/3
* TSAN: org.apache.kudu.backup.TestKuduBackup
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 02:00:08 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24173 )
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2454/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2026 19:19:24 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24173 )
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
[rpc] add PREDICT_FALSE() for unlikely error scenarios
I was looking at the RPC code to clarify a few perf-related questions
and found that PREDICT_{TRUE,FALSE}() were not used uniformly throughout
the code. This patch adds these macros in the rest of relevant places,
where applicable.
This changelist doesn't contain any functional modifications.
Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Reviewed-on: http://gerrit.cloudera.org:8080/24173
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/client_negotiation.h
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/proxy.cc
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc_controller.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/service_pool.cc
13 files changed, 47 insertions(+), 46 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24173 )
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2454/
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Apr 2026 18:35:49 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] add PREDICT FALSE() for unlikely error scenarios
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24173 )
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2026 23:26:16 +0000
Gerrit-HasComments: No