[jira] [Commented] (OFBIZ-5257) Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong

["Pierre Smits (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701906#comment-13701906 ] 

Pierre Smits commented on OFBIZ-5257:
-------------------------------------

Perhaps you did not notice the header of this issue?

I checked the files for methods with their name starting with 'is'. The result was about 35 methods found. I also checked the files for methods with name starting with 'check'. The result was more than 100 methods found.

I would say that best practice regarding method naming for methods that check statuses and such is not in favor of starting with 'is'.

                
> Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-5257
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5257
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>             Fix For: SVN trunk
>
>
> The name of this method in accounting services doesn't tell what it does. 
> You have to go into the description what the functionality of the method is, namely checking whether an invoice is a foreign currency.
> Best practice is to have the name of the function reflect the functionality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira