You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/12/02 12:40:25 UTC
[GitHub] zeppelin pull request #1722: [HOTFIX] substitute null check for the refactor...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1722
[HOTFIX] substitute null check for the refactored Revision class
### What is this PR for?
This is to fix minor bug introduced by #1697
### What type of PR is it?
Bug Fix | Hot Fix
### Todos
* [x] - substitute null check
### What is the Jira issue?
N/A
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin bugfix/revision-EMPTY
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1722.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1722
----
commit 95501b760ef3d7d0c29c25b849720bf9b856b8d2
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T12:37:25Z
fix null -> EMPTY
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1722: [ZEPPELIN-1776] substitute null check for the refactor...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1722
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1722: [ZEPPELIN-1776] substitute null check for the r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1722: [HOTFIX] substitute null check for the refactored Revi...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1722
LGTM thank for the contrib
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1722: [ZEPPELIN-1776] substitute null check for the refactor...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1722
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1722: [HOTFIX] substitute null check for the refactored Revi...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1722
@anthonycorbacho this is done, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1722: [HOTFIX] substitute null check for the refactor...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1722: [HOTFIX] substitute null check for the refactor...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1722
[HOTFIX] substitute null check for the refactored Revision class
### What is this PR for?
This is to fix minor bug introduced by #1697
### What type of PR is it?
Bug Fix
### Todos
* [x] - substitute null check
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1776
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin bugfix/revision-EMPTY
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1722.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1722
----
commit 95501b760ef3d7d0c29c25b849720bf9b856b8d2
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T12:37:25Z
fix null -> EMPTY
commit 13178aee18c0a4aed1dda0c72750e08c9ed9f53c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-03T12:30:56Z
add isEmpty()
commit 0408c9a3159f7e130e524f74d8fbbbca4acffc41
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-03T16:30:43Z
refactor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---