You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pradeep Soundararajan <pr...@citrix.com> on 2013/04/01 09:51:20 UTC
Re: Review Request: BUG-ID: CLOUDSTACK-1689
> On March 29, 2013, 12:46 p.m., ASF Subversion and Git Services wrote:
> > Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/bvt from Prasanna Santhanam <ts...@apache.org>
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ]
> >
> > CLOUDSTACK-1689: KVM agent install.sh should install ipset command
> >
> > Added ipset in cloud.spec as part of agent install.
> >
> > Signed-off-by: Pradeep <pr...@citrix.com>
> > Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> >
I hope I have added as part of debian agent install.
Chip, please review this https://reviews.apache.org/r/10216
- Pradeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18508
-----------------------------------------------------------
On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 10:41 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
>
>
> Description
> -------
>
> BUG-ID: CLOUDSTACK-1689
>
> Summary: KVM agent install.sh should install ipset command
>
> Added ipset in cloud.spec as part of agent install.
>
> Signed-off-by: Pradeep <pr...@citrix.com>
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec e10ae1e
>
> Diff: https://reviews.apache.org/r/9946/diff/
>
>
> Testing
> -------
>
> Packaging ipset properly after this change.
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>
Re: Review Request: BUG-ID: CLOUDSTACK-1689
Posted by Chip Childers <ch...@sungard.com>.
On Mon, Apr 01, 2013 at 07:51:20AM +0000, Pradeep Soundararajan wrote:
>
>
> > On March 29, 2013, 12:46 p.m., ASF Subversion and Git Services wrote:
> > > Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/bvt from Prasanna Santhanam <ts...@apache.org>
> > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ]
> > >
> > > CLOUDSTACK-1689: KVM agent install.sh should install ipset command
> > >
> > > Added ipset in cloud.spec as part of agent install.
> > >
> > > Signed-off-by: Pradeep <pr...@citrix.com>
> > > Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> > >
>
> I hope I have added as part of debian agent install.
>
> Chip, please review this https://reviews.apache.org/r/10216
>
>
> - Pradeep
ACK - and done.