You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/03/04 17:09:15 UTC

[GitHub] [thrift] fishy commented on pull request #2181: THRIFT-5233: Handle I/O timeouts in go library

fishy commented on pull request #2181:
URL: https://github.com/apache/thrift/pull/2181#issuecomment-790775860


   @Trane9991 
   
   1. Yes for both
   2. This is because the way the library/framework works, you would only get io timeouts on the first reads (`ReadMessageBegin`). For client side write (server side read), if you look at `TStandardClient`'s implementation, we always call `WriteMessageBegin`, `Write`, `WriteMessageEnd`, `Flush` without delays between them (https://github.com/apache/thrift/blob/a8c041dd580ff37f3e32b0eaafed542f496d5d58/lib/go/thrift/client.go#L44-L53). For server side write (client side read), it's the same in the compiler generated `Process` functions. The only "delay" that could cause io timeouts are the delaye before calling `WriteMessageBegin`. For server writes those delays are just the actual handler handling the request and generating the response. I described that in the [jira ticket](https://issues.apache.org/jira/browse/THRIFT-5233).
   3. Right.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org