[GitHub] [camel-k] squakez commented on a diff in pull request #4235: fix(#3836) Expose runtime details in kamel version -a -v

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4235:
URL: https://github.com/apache/camel-k/pull/4235#discussion_r1161545431


##########
pkg/cmd/version.go:
##########
@@ -159,15 +161,30 @@ func operatorInfo(ctx context.Context, c client.Client, namespace string) (map[s
 		}
 	}
 
+	catalog, err := camel.LoadCatalog(ctx, c, namespace, v1.RuntimeSpec{Version: platform.Status.Build.RuntimeVersion, Provider: platform.Status.Build.RuntimeProvider})
+	if catalog != nil {
+		for k, v := range catalog.CamelCatalogSpec.Runtime.Metadata {
+			infos[k] = v
+		}
+	} else {
+		log.Debug("Can't load CamelCatalog.")

Review Comment:
   More than logging a debug trace, I think we should expose the error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org