You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/10/13 16:06:04 UTC

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19138


Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................

IMPALA-11655: Impala should set write mode "merge-on-read" by default

Similarly to HIVE-26596 Impala should set merge-on-read write mode
for V2 tables, unless otherwise specified:

* during table creation with 'format-version'='2'
* during alter table set tblproperties 'format-version'='2'

We do so because in the foreseeable future Impala will only support
merge-on-read (on the write-side, on the read side copy-on-write is
also supported). Also, currently Hive only supports merge-on-read.

Testing:
 * e2e tests added

Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
6 files changed, 177 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/19138/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Riza Suminto, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19138

to look at the new patch set (#2).

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................

IMPALA-11655: Impala should set write mode "merge-on-read" by default

Similarly to HIVE-26596 Impala should set merge-on-read write mode
for V2 tables, unless otherwise specified:

* during table creation with 'format-version'='2'
* during alter table set tblproperties 'format-version'='2'

We do so because in the foreseeable future Impala will only support
merge-on-read (on the write-side, on the read side copy-on-write is
also supported). Also, currently Hive only supports merge-on-read.

Testing:
 * e2e tests added

Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
6 files changed, 223 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/19138/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 1:

(3 comments)

Hi Zoltan, the code looks good.
I just have couple nits to discuss if you don't mind.

http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@658
PS1, Line 658: "2"
nit: maybe make this a static final String in IcebergTable.java, so we can track V2 specific codes?

Also, does it makes more sense if it is better to try convert to integer and compare with ">= 2"? I understand there is only V1 and V2 now, but just in case.


http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@839
PS1, Line 839: isAnyWriteModeSet
nit: Result from this method is always negated in all invocation. Maybe consider to change this to "isNoWriteModeSet", and replace the logical operator from disjunction to conjunction?


http://gerrit.cloudera.org:8080/#/c/19138/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test:

http://gerrit.cloudera.org:8080/#/c/19138/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@354
PS1, Line 354: ---- QUERY
             : CREATE TABLE iceberg_upgrade_v2_no_write_mode (i INT) STORED AS ICEBERG;
             : DESCRIBE FORMATTED iceberg_upgrade_v2_no_write_mode;
             : ---- RESULTS: VERIFY_IS_NOT_IN
             : '','write.delete.mode   ','merge-on-read       '
             : '','write.update.mode   ','merge-on-read       '
             : '','write.merge.mode    ','merge-on-read       '
nit: Add one more test where it explicitly set 'format-version'='1'?



-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Oct 2022 23:52:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 2:

(3 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@658
PS1, Line 658: mat
> nit: maybe make this a static final String in IcebergTable.java, so we can 
Done


http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/19138/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@839
PS1, Line 839: isAnyWriteModeSet
> nit: Result from this method is always negated in all invocation. Maybe con
I prefer not to put negations in method names, but it's more of a matter of taste I guess. I can change if you feel strong about it.


http://gerrit.cloudera.org:8080/#/c/19138/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test:

http://gerrit.cloudera.org:8080/#/c/19138/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@354
PS1, Line 354: ---- QUERY
             : CREATE TABLE iceberg_upgrade_v2_no_write_mode (i INT) STORED AS ICEBERG;
             : DESCRIBE FORMATTED iceberg_upgrade_v2_no_write_mode;
             : ---- RESULTS: VERIFY_IS_NOT_IN
             : '','write.delete.mode   ','merge-on-read       '
             : '','write.update.mode   ','merge-on-read       '
             : '','write.merge.mode    ','merge-on-read       '
> nit: Add one more test where it explicitly set 'format-version'='1'?
Done. Also added one in show-create-table.test.



-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:27:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11642/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:29:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8709/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:29:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................

IMPALA-11655: Impala should set write mode "merge-on-read" by default

Similarly to HIVE-26596 Impala should set merge-on-read write mode
for V2 tables, unless otherwise specified:

* during table creation with 'format-version'='2'
* during alter table set tblproperties 'format-version'='2'

We do so because in the foreseeable future Impala will only support
merge-on-read (on the write-side, on the read side copy-on-write is
also supported). Also, currently Hive only supports merge-on-read.

Testing:
 * e2e tests added

Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Reviewed-on: http://gerrit.cloudera.org:8080/19138
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
6 files changed, 223 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 19:37:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 2: Code-Review+1

Thanks for the fix Zoltan, LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:20:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:29:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11628/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Oct 2022 16:26:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 )

Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default
......................................................................


Patch Set 2: Code-Review+2

Looks good, thanks Zoltan!


-- 
To view, visit http://gerrit.cloudera.org:8080/19138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa32472cde98e21fb23f5461175db1bf401db3d
Gerrit-Change-Number: 19138
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:26:48 +0000
Gerrit-HasComments: No