Re: [PR] Use $creationTime for implicit OFFLINE upsert comparison [pinot]

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on PR #19118:
URL: https://github.com/apache/pinot/pull/19118#issuecomment-5173764987

   Simplified further in `3173ea4d27`.
   
   The dedicated physical comparison column has been removed. Pinot now exposes a single built-in hidden virtual column, `$creationTime`, backed directly by the segment index creation time, and OFFLINE upsert selects it only when neither comparison columns nor a time column is configured. `PinotSegmentRecordReader` can read it when explicitly requested, while `SELECT *` continues to hide it.
   
   There are no RefreshSegmentTask production changes. The E2E confirms Refresh preserves the source creation time and that transactional replacement cannot let the rebuilt old segment displace newer data. Focused tests passed (23/23), and the full 63-module E2E reactor passed (956 goals).
   
   Ref: https://github.com/apache/pinot/pull/19118#issuecomment-5170523641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org